use accessibility identifier for error modal

[tomholub]

  checkError = async (errorText: string) => {
    const message = '-ios class chain:**/XCUIElementTypeAlert/XCUIElementTypeOther/XCUIElementTypeOther/' +
      'XCUIElementTypeOther[2]/XCUIElementTypeScrollView[1]/XCUIElementTypeOther[1]/XCUIElementTypeStaticText[2]';//it works only with this selector
    await expect(await this.errorHeader).toBeDisplayed();
    await expect(await $(message)).toHaveAttribute('value', `${errorText}`);
    await expect(await this.okButton).toBeDisplayed();
  }

I'd like this to be renamed to checkErrorModal and be moved to BaseScreen, so that it's reusable across the app.

We use the same code to render error modals everywhere, so we can use same code to check for it everywhere.

[tomholub]

In the same issue, use this general method to look for this modal:

  it('app setup fails with bad EKM URL', async () => {
    const mockApi = new MockApi();
    mockApi.fesConfig = { clientConfiguration: { key_manager_url: 'INTENTIONAL BAD URL' } };
    await mockApi.withMockedApis(async () => {
      await SplashScreen.login();
      // todo - replace the following pause with wait for modal error
      //   that says "Please check if key manager url set correctly"
      await browser.pause(5000);
    });
  });

I'm merging it in #1158 unfinished like this.

[tomholub]

And this one

  it('setup shows meaningful error when FES returns 400', async () => {
    const mockApi = new MockApi();
    mockApi.fesConfig = { returnError: { code: 400, message: "some client err" } };
    await mockApi.withMockedApis(async () => {
      await SplashScreen.login();
      // todo - replace the following pause with wait for modal error
      await browser.pause(5000);
    });
  });
zzz

[fcvakintos]

@tomholub What the expected error for this 'setup shows meaningful error when FES returns 400'?
now I get this error, is it correct?
if yes, i need to create new method for this
and I cant to add accessibility Id for error message, maybe Devs can help me?

[tomholub]

This is a good error, at least for now

[tomholub]

and I cant to add accessibility Id for error message, maybe Devs can help me?

What have you tried?

[fcvakintos]

@tomholub now it has accessibility id = full error message(check screen), we can use it, but better if we will user unique accessibility id for all errors( like "errorMessage")

[tomholub]

Yes, that's what the issue is about. Have you tried to add the accessibilityId?

[fcvakintos]

to this method

but i dont know how to add it