moved checkError method to base.screen, renamed it to checkErrorModal…#1180
Merged
moved checkError method to base.screen, renamed it to checkErrorModal…#1180
Conversation
…, added checking error to mock/setup/SetupFailsWithInconsistentClientConfiguration spec
tomholub
requested changes
Dec 6, 2021
appium/tests/specs/mock/setup/SetupShowsMeaningfulErrorFromFES.spec.ts
Outdated
Show resolved
Hide resolved
tomholub
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, added checking error to mock/setup/SetupFailsWithInconsistentClientConfiguration spec
This PR contains changes for checkError method, it is moved to base screen and renamed as checkErrorModal, added this method to mock/setup/SetupFailsWithInconsistentClientConfiguration spec
close #1162
issue #1179
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):