use XCUIElementTypeAlert for appium tests of modals

[tomholub]

to this method

but i dont know how to add it

Originally posted by @fcvakintos in #1162 (comment)

[Kharchevskyi]

@fcvakintos @tomholub for what elements do you need accessibility id? would it be enough to add to buttons/titles only? or you need id for view of alert as well?

[tomholub]

we'll need it for:

• title (bolded)
• message
• each button

[Kharchevskyi]

For now I couldn't find a correct way how to add custom accessibility identifiers to UIAlertControllers.
After some investigations I found next issues:

• in case we add aid to controller's view alert.view.accessibilityIdentifier = "aid-pass-phrase-alert" all other elements, like buttons became not accessible. Please check screenshot.

• it is possible to add via Apple's private APIs. But this solution is fragile and actually not recommended by Apple.
  https://stackoverflow.com/questions/38117410/how-can-i-set-accessibilityidentifier-to-uialertcontroller

• It looks like it is possible to get elements (title, message, buttons) by their default ids.
  @fcvakintos correct me if I wrong, but I think it would be enough for tests?

[tomholub]

Not good to use private apis.

In this particular case, we'll have to go with the default accessibility ids like ok and cancel.

What is the default accessibility id of the title and message? Would it be Pass Phrase and Confirm Pass Phrase respectively?

[sosnovsky]

I also found driver.getAlertText() function which gives full text of current alert, so it'll return Pass Phrase\nConfirm Pass Phrase
And for checking if alert is shown I use -ios predicate string:type == 'XCUIElementTypeAlert' selector.

Checking alert text looks like this:

get currentModal() {
  return $("-ios predicate string:type == 'XCUIElementTypeAlert'");
}

checkModalText = async (message: string) => 
  await ElementHelper.waitElementVisible(await this.currentModal);
  const alertText = await driver.getAlertText();
  expect(alertText).toEqual(message);
}

Maybe this findings will be useful for this issue too.

[tomholub]

I like Roman's approach, clear and straight forward.

[tomholub]

That means, for this issue, @fcvakintos please update the tests to use that approach.

@Kharchevskyi thanks for looking into this.