remove separate pass phrase table, add as a column on keys table

[tomholub]

It's an odd choice for a database schema to make user entered pass phrase string a primary key.

//
//  PassPhraseInfo.swift
//  FlowCrypt
//
//  Created by Anton Kharchevskyi on 04.06.2021.
//  Copyright © 2021 FlowCrypt Limited. All rights reserved.
//

import Foundation
import RealmSwift

/// PassPhrase object to store in Realm
final class PassPhraseObject: Object {
    @objc dynamic var value: String = ""
    let allFingerprints = List<String>()

    convenience init(
        value: String = "",
        fingerprints: [String]
    ) {
        self.init()
        self.value = value
        self.allFingerprints.append(objectsIn: fingerprints)
    }

    override class func primaryKey() -> String? {
        "value"
    }
}

// MARK: - Convenience
extension PassPhraseObject {
    var primaryFingerprint: String {
        allFingerprints[0]
    }

    convenience init(_ passPhrase: PassPhrase) {
        self.init(value: passPhrase.value, fingerprints: passPhrase.fingerprints)
    }
}

extension PassPhrase {
    init(object: PassPhraseObject) {
        self.value = object.value
        self.fingerprints = Array(object.allFingerprints)
        self.date = nil
    }
}

[tomholub]

The appropriate way to fix this would be to add pass phrase as an optional field on the "keys" table.

No reason to have a separate table for pass phrases, each pass phrase is for a particular key.

[sosnovsky]

Do we need to use migrations here? Or we don't have many test users and db schema change can be done without adding migration?

[tomholub]

can change schema without migrations. thanks