[code ok] issue 441 remove passphrase table#577
Merged
Conversation
tomholub
reviewed
Sep 30, 2021
Collaborator
tomholub
left a comment
There was a problem hiding this comment.
Still need to go through the rest of the code (checked about half) but it's looking good. Left some comments.
FlowCrypt/Functionality/Services/Key Services/InMemoryPassPhraseStorage.swift
Show resolved
Hide resolved
This was referenced Sep 30, 2021
tomholub
reviewed
Sep 30, 2021
Collaborator
tomholub
left a comment
There was a problem hiding this comment.
Other than earlier comment about forgetting pass phrases on logout, the code looks good. Will now do manual testing.
tomholub
reviewed
Oct 1, 2021
Collaborator
tomholub
left a comment
There was a problem hiding this comment.
Looks good, waiting for updated xcode to try
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes PassPhraseObject model and adds optional
passphrasefield toKeyInfoclass.close #441
Tests:
testKeyInfoInittestTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):