Signed-only messages not recognized as signed#1088
Conversation
ivan-ushakov
changed the title
|
Still fighting with email crafting for UI tests |
|
@tomholub
For the first one I can not use |
For this one I used my email generator and created signed message with generated key pair (not published anywhere).
For this one I just sent signed email with browser extension, downloaded original message in MIME and changed message text from |
|
UI tests failing because I added new messages and now you need to scroll down to have them visible. I agree about using Search functionality in UI tests for this. |
in progress here #1103 |
|
I moved UI test to search approach to save some time. |
|
@ivan-ushakov master tests are fixed now |
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
This is excellent! With one problem below.
I'm not sure if the problem is in the supplied message or in the app code.
| // signed only message where the pubkey is not available | ||
| await MailFolderScreen.clickSearchButton(); | ||
| await SearchScreen.searchAndClickEmailBySubject('Signed only message where the pubkey is not available'); | ||
|
|
||
| await EmailScreen.checkEncryptionBadge('decrypt error'); | ||
| await EmailScreen.clickBackButton(); |
There was a problem hiding this comment.
This one is not right - signed only message that is missing pubkey should have encryption badge of not encrypted and a signature badge that says it cannot be verified due to missing pubkey.
There was a problem hiding this comment.
Maybe email was crafter with error. Let's create separate issue
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
I'll merge it either way, as it is an improvement and adds a great test.
But that case needs to be debugged.
2 participants
close #1020
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):