added new method - scrollToElement, updated test, added checking Inb…

[fcvakintos]

…ox screen after reopening app

This PR contains fixes for tests, added new method for scrolling down to element

close #1071

---

Tests

• Tests added or updated

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[tomholub]

@fcvakintos this is an improvement but it does not close the issue. The issue was about using the search functionality to find inbox elements, instead of scrolling to them.

You have to have a long-term view. We started with 1 email. Now there's 20. There will probably be 300 by the time we are done writing all these tests. Scrolling to them is not scalable.

[tomholub]

I can merge this but change the close to issue in the description, and then followup with a PR that uses the search icon.

[fcvakintos]

@tomholub I will update the test

[tomholub]

Do you want to do it in this PR or separately?

[fcvakintos]

@tomholub in this PR

[tomholub]

Ok. I marked it as draft until then. To recap:

• for tests that check message content of a particular message, or test the reply button (without actually sending reply) etc : use search
• for tests that go from folder to folder (sent / trash etc) use scroll

[fcvakintos]

@tomholub I think search is not working correctly
I tried to search by email subject and get a lot of emails in response
try with this subject - "encrypted email"

[fcvakintos]

@tomholub and it search from all list(Sent/Inbox and other) - I think it should search only from the list of selected section

[tomholub]

I think it's because "encrypted email" is included as a PGP header comment in every encrypted email

-----BEGIN PGP MESSAGE-----
Version: FlowCrypt iOS 0.2 Gmail Encryption
Comment: Seamlessly send and receive encrypted email

wV4DZQdhGPK/uXASAQdAB5494lpT81X77JPQp7Un547GRSUVnEBcv8IvEl5u
9Vww2GgQifhIQDu7kB3McqzL5y+24hiiALM8HRaKnJrAVAV2iKIl7xlIN6le
Nvu2tYGfwV4DFS6Vc++zZ+oSAQdAngKdfuE8RwlwZj741VPUMGHvM5KuQnHI
gYnd5o+wbWQwVWlEk6tG4AtvWrttqW/jGz36vInCs+10cfcm7YUH7XmZLrM0
OR/K6q88L/ANFwaH0sC7AamuqJVrmcAQsy0KTQNURwWpucEb7GlsweitvuyG
Z7BZBpm4CXGsmudk6eYHleEHrD5DH4VmJS1W8VgbpXXklLE3RN+s0R/73Xt/
3WDkzKnE/a8qg+SxpTtcK6QvzHSTEaVdtFVusQ5iwgrS95PD4T1SPYgwKU98
WTar1k2bf8jIKq7xPTvldlsmmsJBIyT3ns7zvM7iNu+IMfgelNTHFFfqJija
MNep5WvA035dUtPOA88DhnaSMVgcYqojc4vrZ3s6m1UMUm9Ik/PSBj7CM7Vv
KWS8jMNPhaXCCVvFZxTPKyHhHJrBT/HIZrGN/Acy8lLCUIhxMQ56PQCrTLz8
X16Z4SDkizmRHms/CBtCLLPJJqK1NpywmmG7eFcXkObpA9lP64Fe7WeQuzom
xj8+B2CwsesjstFUVIjXWWat4eSf1BC20ffa8ERa9P2akiRJzALlA7D/ovif
uOegizsO3bzFD33998lFMXgjCr61AY3UF3ZW9DRncsUIZw==
=NcWZ
-----END PGP MESSAGE-----

so that's not a fortunate combination of words to search. You can do the following things:

• rename that email to something less generic
• try to put the search term in quotes (which won't help this particular situation, but could help in general)
• try a query like subject:"search string here" which would only search subject - hopefully

[tomholub]

The search works on all folders on purpose - users were getting confused when they couldn't find email they archived etc.

[fcvakintos]

@tomholub yeah, this case works try a query like subject:"search string here" which would only search subject - hopefully
thanks

[tomholub]

Thanks!