added MailFolder, moved trash,inbox,sent screens to mailFolderScreen#1092
Merged
added MailFolder, moved trash,inbox,sent screens to mailFolderScreen#1092
Conversation
tomholub
requested changes
Nov 25, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Looks good - less duplication.
When you encounter any ios class chain kind of selector, use accessibility identifiers instead.
tomholub
previously approved these changes
Nov 25, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
I can merge it since it was filed as a separate issue, but merge conflicts need to be resolved first.
# Conflicts: # appium/tests/screenobjects/sent.screen.ts # appium/tests/screenobjects/trash.screen.ts
Contributor
Author
|
resolved |
Contributor
Author
|
@tomholub can you merge it |
tomholub
approved these changes
Nov 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains new mailFolderScreen, which has methods from trash,inbox,sent screens, removed trash/inbox/sent srcreens
close #1044
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):