Add accessibility ID for headers

[fcvakintos]

Looks good - less duplication.

When you encounter any ios class chain kind of selector, use accessibility identifiers instead.

Originally posted by @tomholub in #1092 (review)

[fcvakintos]

@ivan-ushakov can you help me with accessibility IDs for headers?
I dont know how to add it, i need to add it to all screens(sent/inbox/trash)
i think it should be here for inbox screen
how can i add it?

[fcvakintos]

will add accessibilityid for search icon and help icon
CREATE_EMAIL_BUTTON: '-ios class chain:**/XCUIElementTypeButton[label == "+"]', INBOX_HEADER: '-ios class chain:**/XCUIElementTypeStaticText[label == "INBOX"]', SEARCH_ICON: '~search icn', HELP_ICON: '~help icn' HELP_ICON: '~help icn', SEARCH_FIELD: '~Search All Mail'

[fcvakintos]

@tomholub how from devs can help me?

[tomholub]

@Kharchevskyi please take a look when you have a chance

[ivan-ushakov]

@ivan-ushakov can you help me with accessibility IDs for headers?
I dont know how to add it, i need to add it to all screens(sent/inbox/trash)

Try this one:

    private func setupUI() {
        title = inboxTitle
        view.accessibilityIdentifier = inboxTitle

        tableNode.do {
            $0.delegate = self
            $0.dataSource = self
            $0.leadingScreensForBatching = 1
            $0.view.refreshControl = refreshControl
            node.addSubnode($0)
        }

        node.addSubnode(composeButton)
        refreshControl.addTarget(self, action: #selector(refresh), for: .valueChanged)
    }

[Kharchevskyi]

or better to add them to navigationController?.navigationItem.titleView?.accessibilityIdentifier = inboxTitle instead of view.accessibilityIdentifier = inboxTitle. Please check if this works for you

[fcvakintos]

view.accessibilityIdentifier = inboxTitle didnt help me too