Add accessibility id to navigation title

[Kharchevskyi]

This PR adds accessibility id to navigation title

close #1094

---

Tests:

• Does not need tests (refactor only, docs or internal changes)

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[Kharchevskyi]

@fcvakintos can you please take a look if this solution works for you?

[fcvakintos]

@Kharchevskyi it doesn't work for me.
no accessibility Id for headers

[Kharchevskyi]

Got it. Will then try another solution.
Will keep you in touch

[Kharchevskyi]

@fcvakintos Please check if this what you are looking for. If yes, I will update PR with normal UI

[fcvakintos]

@Kharchevskyi doesnt work for me

[Kharchevskyi]

@fcvakintos please check latest commit.

[fcvakintos]

@Kharchevskyi doesnt work

[Kharchevskyi]

let's schedule a meeting and try to find where the problem is
https://github.com/FlowCrypt/org - you can fin email ther

[tomholub]

@fcvakintos could you also please demonstrate how can we inspect the layout the way you are inspecting it?

[fcvakintos]

@tomholub for that I am using https://github.com/appium/appium-inspector

[Kharchevskyi]

I can try to setup it and try locally, but I would need some time, because I'm not familiar with Appium

[tomholub]

Please try, and document the steps so that another person not familiar with appium can do the same. Ask @fcvakintos if you get stuck.

That way we'll all be able to debug these things directly.

[Kharchevskyi]

@fcvakintos can you please share your config for https://github.com/appium/appium-inspector

[fcvakintos]

@Kharchevskyi please replace path to app

{
"platformName": "iOS",
"iosInstallPause": 5000,
"deviceName": "iPhone 13",
"app": "path to app",
"platformVersion": "15",
"automationName": "XCUITest",
"newCommandTimeout": 10000,
"wdaLaunchTimeout": 300000,
"wdaConnectionTimeout": 600000,
"wdaStartupRetries": 4,
"wdaStartupRetryInterval": 120000
}

[tomholub]

The inspector should be added to package.json so it gets auto-installed. That means fewer steps for someone who wants to use it.

[fcvakintos]

we don't need it in package.json

[tomholub]

I didn't say we need it. I said that if we add it there, then other developers who need to use it don't have to install it separately. Isn't that true?

[fcvakintos]

I am using mac app installation, not npm

[tomholub]

Understood - I assumed it could be installed from npm, which is not the case.

[Kharchevskyi]

@fcvakintos would this work for you?

[fcvakintos]

@Kharchevskyi you don't have accessibility Id for header now
check screen, here is accessibility id

[Kharchevskyi]

@fcvakintos please confirm this is what you are looking for

[fcvakintos]

@Kharchevskyi we can use "choosePassPhrase" - it is better i think

[Kharchevskyi]

according to suggestion
#1127 (comment)

[fcvakintos]

@Kharchevskyi yes, but it is not correct, i think it should be 1 word, can we change it?

[tomholub]

@fcvakintos if it should be one word, then I suggest navigationItemChoosePassPhrase which would be done dynamically something like navigationItem\(title.replace(" ", "")). @Kharchevskyi could you do that?

[tomholub]

@Kharchevskyi later please add to appium/README.md how to install and use the above tool and how to configure it so that others can also do it. I'm filing a separate issue.

[Kharchevskyi]

Yes, sure. Will make it as one word - navigationItemChoosePassPhrase and so on

[tomholub]

I assume this is ready to merge

[tomholub]

@Kharchevskyi or not yet?

[tomholub]

I'll merge it either way, if there is work left to do, can do another PR.

[fcvakintos]

@Kharchevskyi @tomholub I found new issue after this fix, now we dont have accesibility id for menu bar items
it is after this fix i think, because now accessibility id = "INBOX" is not unique

can we add accessibility id for menu bar items?
something like this - menubarIteminbox, menubaritemchat and etc

[Kharchevskyi]

Can't be related to this changes, but will do asap