Conversation
tomholub
approved these changes
Dec 13, 2021
Comment on lines
4
to
8
| const SELECTORS = { | ||
| BACK_BTN: '~arrow left c' | ||
| BACK_BTN: '~arrow left c', | ||
| SAVE_BTN: '-ios class chain:**/XCUIElementTypeButton[`label == "Save"`]', | ||
| CANCEL_BTN: '~Cancel', | ||
| }; |
Collaborator
There was a problem hiding this comment.
I'll file issue to add accessibility ids to these three, aid-back-icon, aid-save-attachment-to-device and aid-cancel-saving-attachment
| checkDownloadPopUp = async (name: string) => { | ||
| await (await this.backButton).waitForDisplayed(); | ||
| await (await this.cancelButton).waitForDisplayed(); | ||
| const attachment = `-ios class chain:**/XCUIElementTypeNavigationBar[\`name == "com_apple_DocumentManager_Service.DOCServiceTargetSelectionBrowserView"\`]/XCUIElementTypeButton/XCUIElementTypeStaticText`;//it works only with this selector |
Collaborator
There was a problem hiding this comment.
Need accessibility id aid-attachment-name-container
|
|
||
| checkAttachment = async (name: string) => { | ||
| await (await this.backButton).waitForDisplayed(); | ||
| const attachmentHeader = `-ios class chain:**/XCUIElementTypeNavigationBar[\`name == "${name}"\`]`; |
Collaborator
There was a problem hiding this comment.
aid-attachment-header-name
| WRONG_PASS_PHRASE_MESSAGE: '-ios class chain:**/XCUIElementTypeStaticText[`label == "Wrong pass phrase, please try again"`]', | ||
| ATTACHMENT_CELL: '~attachmentCell0', | ||
| ATTACHMENT_TITLE: 'attachmentTitleLabel0', | ||
| ATTACHMENT_TITLE: '~attachmentTitleLabel0', |
Collaborator
There was a problem hiding this comment.
aid-attachment-title-label-0
Comment on lines
12
to
13
| REPLY_BUTTON: '~replyButton', | ||
| RECIPIENTS_BUTTON: '~messageRecipientButton', |
Collaborator
There was a problem hiding this comment.
aid-reply-icon and aid-message-recipients-tappable-area
Collaborator
|
Very good. I'll file a separate issue to add / update more accessibility ids. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes for check email with attachment spec, added new methods, updated selectors
close #1204
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):