#1337 Include names for from/to/cc/bcc emails#1398
Merged
Conversation
# Conflicts: # FlowCrypt/Controllers/Compose/ComposeViewController.swift # FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageRecipient.swift
Collaborator
|
@ioanmo226 please have a look at bringing this up to date to master, and then fixing / finalizing. The goal was to include names of recipients in a particular API (that until now only included email addresses), but it seems it turned out a little larger change than expected. |
tomholub
requested changes
Mar 22, 2022
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
This looks pretty good, but has an issue + some other comments - see below.
FlowCrypt/Functionality/Services/Contacts Service/Models/RecipientWithSortedPubKeys.swift
Outdated
Show resolved
Hide resolved
tomholub
reviewed
Mar 22, 2022
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Already looks better. Once the above resolved, I'll do some testing and could merge it. Thanks!
tomholub
previously approved these changes
Mar 22, 2022
Collaborator
|
@ioanmo226 please have a look at tests |
tomholub
previously approved these changes
Mar 23, 2022
tomholub
previously approved these changes
Mar 23, 2022
tomholub
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds names to sender and recipients fields
close #1337
close #1437
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):