Conversation
Collaborator
|
if u r running out of issues, please self assign #441 from anton. thank you!
…On Wednesday, September 29, 2021, Roma Sosnovsky ***@***.***> wrote:
This PR fixes "fetch keys" error for accounts with EKM set up.
close #516 <#516>
------------------------------
*Tests*:
- Tests added - this issue was caused by unique() function which
sometimes changed array order. I added test_unique test for validating
array order
------------------------------
To be filled by reviewers
I have reviewed that this PR... *(tick whichever items you personally
focused on during this review)*:
- addresses the issue it closes (if any)
- code is readable and understandable
- is accompanied with tests, or tests are not needed
- is free of vulnerabilities
- is documented clearly and usefully, or doesn't need documentation
------------------------------
You can view, comment on, or merge this pull request online at:
#567
Commit Summary
- issue #516 fix unique method wrong order
<08b982d>
- Merge branch 'master' into bugfix/issue-516-keys-fetch
<50e4f7f>
- issue #516 add test for unique() order
<7320d10>
File Changes
- *M* FlowCryptAppTests/ExtensionTests.swift
<https://github.com/FlowCrypt/flowcrypt-ios/pull/567/files#diff-7e0b55f5605ce4832ea2a5e59251a5f0122f06ef71ea4778f092d4e2f1d1d7c3>
(8)
- *M* FlowCryptCommon/Extensions/CollectionExtensions.swift
<https://github.com/FlowCrypt/flowcrypt-ios/pull/567/files#diff-18dc89574f28f700fc2030c0c1f75dede34803d893c11eeacecaabe03d714246>
(3)
Patch Links:
- https://github.com/FlowCrypt/flowcrypt-ios/pull/567.patch
- https://github.com/FlowCrypt/flowcrypt-ios/pull/567.diff
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#567>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQDZEMCGHY6RYOWOIHQXTTUELXGBANCNFSM5E7TCFKQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
--
Tom James Holub <http://holub.me/>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes "fetch keys" error for accounts with EKM set up.
close #516
Tests:
unique()function which sometimes changed array order. I addedtest_uniquetest for validating array orderTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):