Skip to content

Bugfix/issue 516 keys fetch#567

Merged
tomholub merged 3 commits intomasterfrom
bugfix/issue-516-keys-fetch
Sep 29, 2021
Merged

Bugfix/issue 516 keys fetch#567
tomholub merged 3 commits intomasterfrom
bugfix/issue-516-keys-fetch

Conversation

@sosnovsky
Copy link
Collaborator

This PR fixes "fetch keys" error for accounts with EKM set up.

close #516


Tests:

  • Tests added - this issue was caused by unique() function which sometimes changed array order. I added test_unique test for validating array order

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from tomholub September 29, 2021 11:04
@tomholub
Copy link
Collaborator

tomholub commented Sep 29, 2021 via email

Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomholub tomholub merged commit 4cce901 into master Sep 29, 2021
@tomholub tomholub deleted the bugfix/issue-516-keys-fetch branch September 29, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

notReady - could not fetch keys

2 participants