Merged
Conversation
Collaborator
Author
|
@tomholub new builds are failing on semaphore with such error log Do you know possible reason? Maybe some configs were changed? |
Collaborator
|
@sosnovsky please write them on support - |
Contributor
|
@tomholub @sosnovsky it looks that job for and second time in lane |
Collaborator
|
I don't think there is any reason for doing it twice, checkout in prologue should be enough. |
Collaborator
|
@Kharchevskyi thank you - that was it! 👍 |
tomholub
approved these changes
Oct 5, 2021
Contributor
|
i think this PR can be closed #620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR replaces boolean values for passphrases storage with
StorageMethodenumclose #583
Tests:
PassPhraseStorageTeststo use newstorageMethodparamTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):