Skip to content

issue #583 add StorageMethod enum#607

Merged
tomholub merged 2 commits intomasterfrom
feature/issue-583-storage-method
Oct 5, 2021
Merged

issue #583 add StorageMethod enum#607
tomholub merged 2 commits intomasterfrom
feature/issue-583-storage-method

Conversation

@sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Oct 5, 2021

This PR replaces boolean values for passphrases storage with StorageMethod enum

close #583


Tests:

  • Tests added or updated - updated PassPhraseStorageTests to use new storageMethod param

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from tomholub October 5, 2021 14:06
tomholub
tomholub previously approved these changes Oct 5, 2021
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tomholub tomholub enabled auto-merge (squash) October 5, 2021 14:10
@sosnovsky
Copy link
Collaborator Author

@tomholub new builds are failing on semaphore with such error log

fatal: Unable to read current working directory: No such file or directory
fatal: fetch-pack: invalid index-pack output
bash: cd: /Users/semaphore/git/flowcrypt-ios: No such file or directory

Do you know possible reason? Maybe some configs were changed?

@tomholub
Copy link
Collaborator

tomholub commented Oct 5, 2021

@sosnovsky please write them on support - checkout is a semaphore cli command that is supposed to work. So the problem is in their systems this time. https://semaphoreci.com/contact - send them a link to the failing pipeline.

@Kharchevskyi
Copy link
Contributor

@tomholub @sosnovsky it looks that job for TypeScript - Core standalone tests are not configured properly.
Checkout operation performs twice, once inside prologue

prologue:
        commands:
          - checkout

and second time in lane

- name: TypeScript - Core standalone tests
          commands:
            - sem-version node 12
            - checkout

Are there any reasons to do this twice?
Screenshot 2021-10-05 at 22 26 18

@tomholub
Copy link
Collaborator

tomholub commented Oct 5, 2021

I don't think there is any reason for doing it twice, checkout in prologue should be enough.

@tomholub
Copy link
Collaborator

tomholub commented Oct 5, 2021

@Kharchevskyi thank you - that was it! 👍

@tomholub tomholub merged commit 5d6ac07 into master Oct 5, 2021
@tomholub tomholub deleted the feature/issue-583-storage-method branch October 5, 2021 19:57
@Kharchevskyi
Copy link
Contributor

i think this PR can be closed #620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use enum for StorageMethod

3 participants