Skip to content

Update jampy parameters#28

Merged
tomusdrw merged 3 commits intoFluffyLabs:mainfrom
dakk:main
May 5, 2026
Merged

Update jampy parameters#28
tomusdrw merged 3 commits intoFluffyLabs:mainfrom
dakk:main

Conversation

@dakk
Copy link
Copy Markdown
Contributor

@dakk dakk commented Apr 28, 2026

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configurations across multiple jobs for consistency in command-line argument handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

📝 Walkthrough

Walkthrough

Four GitHub Actions workflow files are updated to replace the --socket-file CLI flag with --sock in the docker_cmd argument passed to reusable workflow invocations for jampy and jampy-recompiler targets.

Changes

Socket Flag Standardization

Layer / File(s) Summary
Workflow Configuration
.github/workflows/jampy-fuzz.yml, .github/workflows/jampy-performance.yml, .github/workflows/jampy-recompiler-fuzz.yml, .github/workflows/jampy-recompiler-performance.yml
The docker_cmd parameter in all four workflow definitions replaces --socket-file {TARGET_SOCK} with --sock {TARGET_SOCK} when invoking reusable demo/performance/fuzz workflows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • FluffyLabs/jam-testing#16: Both PRs modify the same GitHub Actions workflow inputs for jampy/jampy-recompiler—specifically the docker_cmd socket flag (--socket-file vs --sock).
  • FluffyLabs/jam-testing#6: Directly modifies the same workflow inputs (docker_cmd) in the jampy workflow—changing --socket-file to --sock.
  • FluffyLabs/jam-testing#3: Both PRs modify the workflow invocations' docker_cmd argument for performance/fuzz workflows (changing the socket flag syntax).

Poem

🐰 The flags go hopping, dancing free,
From --socket-file to --sock with glee!
Four workflows now align their call,
With unified flags across them all.
A harmonious change, both short and sweet! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, using non-descriptive language that doesn't convey the specific nature of the changes (CLI flag updates across multiple workflow files). Consider using a more specific title like 'Update jampy CLI flag from --socket-file to --sock in workflows' to clearly indicate the actual changes made.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/jampy-recompiler-performance.yml:
- Line 16: The workflow references a private image via the docker_image key
'ghcr.io/dakk/jampy-target:0.7.2' which will 401 without auth; fix by adding
GHCR authentication to the job (e.g., add a step before pulling the image that
logs in to ghcr.io using actions/docker/login or similar with username
GITHUB_ACTOR and password from a token secret like GITHUB_TOKEN or a personal
access token and ensure job permissions (packages: read) allow package access),
or alternatively make the referenced image 'ghcr.io/dakk/jampy-target:0.7.2'
public in GHCR so no login is required.
- Around line 15-17: Add a .gitkeep file to both teams/jampy-recompiler/ and
teams/jampy/ so the dashboard will include these teams; create an empty .gitkeep
(or a single-line comment) in each directory, stage and commit the two files,
and push the change—this ensures the existing entries referenced by
target_name/docker_image/docker_cmd in the workflow are not silently skipped due
to missing .gitkeep files.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5dcb4f3b-ea00-4629-b3b9-b1f2262dde8c

📥 Commits

Reviewing files that changed from the base of the PR and between 7792eb6 and 38d0c4a.

📒 Files selected for processing (4)
  • .github/workflows/jampy-fuzz.yml
  • .github/workflows/jampy-performance.yml
  • .github/workflows/jampy-recompiler-fuzz.yml
  • .github/workflows/jampy-recompiler-performance.yml

Comment on lines 15 to +17
target_name: jampy-recompiler
docker_image: 'ghcr.io/dakk/jampy-target:0.7.2'
docker_cmd: '--use-recompiler --socket-file {TARGET_SOCK}'
docker_cmd: '--use-recompiler --sock {TARGET_SOCK}'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify teams directory exists for jampy-recompiler and jampy
fd --type d "^(jampy|jampy-recompiler)$" teams/
fd ".gitkeep" teams/jampy/ teams/jampy-recompiler/ 2>/dev/null

Repository: FluffyLabs/jam-testing

Length of output: 103


Add .gitkeep files to the teams/jampy-recompiler/ and teams/jampy/ directories.

The teams/jampy-recompiler/ and teams/jampy/ directories exist, but they are missing the required .gitkeep files. Per guidelines, both the directory and the .gitkeep file are mandatory; without it, the dashboard will silently skip this team's data.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/jampy-recompiler-performance.yml around lines 15 - 17, Add
a .gitkeep file to both teams/jampy-recompiler/ and teams/jampy/ so the
dashboard will include these teams; create an empty .gitkeep (or a single-line
comment) in each directory, stage and commit the two files, and push the
change—this ensures the existing entries referenced by
target_name/docker_image/docker_cmd in the workflow are not silently skipped due
to missing .gitkeep files.

Comment thread .github/workflows/jampy-recompiler-performance.yml
@tomusdrw tomusdrw merged commit 7d89629 into FluffyLabs:main May 5, 2026
29 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants