Add jamzilla and jamzilla-int performance workflows#3
Add jamzilla and jamzilla-int performance workflows#3tomusdrw merged 3 commits intoFluffyLabs:mainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughTwo new GitHub Actions workflows are introduced for scheduled performance testing of jamzilla and jamzilla-int, each configured to run daily and on manual dispatch. The README is updated to document these new performance monitoring entries in the Minifuzz + Performance team table. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip Migrating from UI to YAML configuration.Use the |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/jamzilla-performance.yml (1)
13-13: Pin the Docker image to an immutable digest for reproducible performance tracking.The mutable tag
:edgeallows the underlying image to change between runs, which can cause benchmark fluctuations unrelated to code changes.Suggested change
- docker_image: 'ghcr.io/ascrivener/jamzilla-tiny:edge' + docker_image: 'ghcr.io/ascrivener/jamzilla-tiny@sha256:<resolved_digest>'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/jamzilla-performance.yml at line 13, The Docker image is pinned to a mutable tag ("docker_image: 'ghcr.io/ascrivener/jamzilla-tiny:edge'") which can change between runs; update the value to a specific immutable digest (sha256) to ensure reproducible performance tracking by replacing the ":edge" tag with the image@sha256:<digest> form; obtain the correct digest from the registry (e.g., ghcr.io manifest or `docker pull` + `docker inspect --format='{{index .RepoDigests 0}}'`) and set docker_image to that full digest string.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/jamzilla-performance.yml:
- Line 13: The Docker image is pinned to a mutable tag ("docker_image:
'ghcr.io/ascrivener/jamzilla-tiny:edge'") which can change between runs; update
the value to a specific immutable digest (sha256) to ensure reproducible
performance tracking by replacing the ":edge" tag with the image@sha256:<digest>
form; obtain the correct digest from the registry (e.g., ghcr.io manifest or
`docker pull` + `docker inspect --format='{{index .RepoDigests 0}}'`) and set
docker_image to that full digest string.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0b2ebdfd-b28a-4762-8cb5-2c0a6131b9bd
📒 Files selected for processing (5)
.github/workflows/jamzilla-int-performance.yml.github/workflows/jamzilla-performance.ymlREADME.mdteams/jamzilla-int/.gitkeepteams/jamzilla/.gitkeep
Adds two new team entries for jamzilla (JIT mode) and jamzilla-int (interpreter mode):
jamzilla-performance.ymlandjamzilla-int-performance.ymlghcr.io/ascrivener/jamzilla-tiny:edge-socket {TARGET_SOCK}PVM_MODE=jit(jamzilla) /PVM_MODE=interpreter(jamzilla-int)teams/jamzilla/andteams/jamzilla-int/