Skip to content

Drop docker_cmd for graymatter performance#37

Merged
tomusdrw merged 1 commit intomainfrom
graymatter-performance-no-cmd
May 6, 2026
Merged

Drop docker_cmd for graymatter performance#37
tomusdrw merged 1 commit intomainfrom
graymatter-performance-no-cmd

Conversation

@tomusdrw
Copy link
Copy Markdown
Member

@tomusdrw tomusdrw commented May 6, 2026

Summary

Mirrors #35 for the performance job.

Test plan

  • Confirm scheduled Performance: graymatter workflow run starts the target with no CLI args and completes minifuzz + picofuzz suites.
  • Confirm other targets' performance workflows (which still set docker_cmd) are unaffected.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflows to improve build configuration flexibility.

Mirrors #35 (which dropped docker_cmd from the graymatter fuzz job) for
the performance job. The graymatter target rejects the legacy
fuzz-m1-target CLI args and instead reads JAM_FUZZ_SOCK_PATH etc. from
the standard target packaging env vars (added in #33).

- graymatter-performance.yml: drop docker_cmd entirely.
- reusable-picofuzz.yml: docker_cmd is now optional (default "").

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9cbf6326-ce5b-4254-b60c-4d0bf736d3b0

📥 Commits

Reviewing files that changed from the base of the PR and between 12a0738 and e13ebe5.

📒 Files selected for processing (2)
  • .github/workflows/graymatter-performance.yml
  • .github/workflows/reusable-picofuzz.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/graymatter-performance.yml

📝 Walkthrough

Walkthrough

The docker_cmd input parameter in the reusable picofuzz workflow was made optional with an empty string default and updated description. The graymatter-performance workflow was updated to remove the explicit passing of this parameter, relying on the new default behavior.

Changes

Workflow Configuration Update

Layer / File(s) Summary
Reusable Workflow Parameter
.github/workflows/reusable-picofuzz.yml
docker_cmd input changed from required: true to required: false with default: "" and expanded description noting placeholder behavior and environment-based reads.
Consumer Workflow Integration
.github/workflows/graymatter-performance.yml
Removed the explicit docker_cmd input passing from the reusable workflow invocation, allowing the default empty value to be used.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • FluffyLabs/jam-testing#35: Both PRs make the docker_cmd input optional and remove/stop passing docker_cmd for graymatter workflows.
  • FluffyLabs/jam-testing#28: Both PRs modify usage of the same reusable workflow input docker_cmd (one makes it optional/removes an invocation; the other changes the argument value passed).

Poem

🐰 Once rigid and stern, now docker_cmd bends,
Optional whispers through workflows and friends,
A default so gentle, an empty string's grace,
Flexibility blooms in the CI/CD space! 🌱

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing docker_cmd from the graymatter performance workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch graymatter-performance-no-cmd

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomusdrw tomusdrw merged commit 4422531 into main May 6, 2026
29 checks passed
@tomusdrw tomusdrw deleted the graymatter-performance-no-cmd branch May 6, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant