Conversation
These four teams ship pure docker-image targets in davxy/jam-conformance:scripts/targets.json with gp_version 0.7.2, matching the same minimal pattern this repo already uses for graymatter et al. (image-only, no docker_cmd — relies on the standard JAM_FUZZ_* env vars). Maintainer mentions for the fuzz workflows are sourced from the original PRs/issues on jam-conformance. Also drops the stale "Dashboard deploy workflow trigger" step from agents.md: deploy-dashboard.yml no longer uses workflow_run.workflows and discovers teams dynamically from teams/*/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughAdds multiple GitHub Actions workflows (fuzz and performance) for several targets and updates README and agents.md to add status entries and enforce a workflow naming convention; workflows delegate to existing reusable workflows with target-specific inputs. ChangesWorkflows and Documentation
Sequence Diagram(s)sequenceDiagram
autonumber
participant GitHub as GitHub Scheduler / PR
participant Workflow as Workflow YAML (repo)
participant Reusable as Reusable Workflow (demo-source / reusable-picofuzz)
participant Runner as Actions Runner -> Docker Target
GitHub->>Workflow: schedule / manual / PR trigger
Workflow->>Reusable: call reusable workflow with inputs (target_name, docker_image, mention?)
Reusable->>Runner: spin up Docker image (docker_image) and run tests
Runner-->>Reusable: results (artifacts / status)
Reusable-->>Workflow: workflow outcome
Workflow-->>GitHub: report status / post issues (if configured)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/jamduna-performance.yml:
- Around line 14-16: The workflow is missing the required docker_cmd input;
update the job configuration that sets target_name and docker_image to also
include docker_cmd and set it to a command that references the socket
placeholder {TARGET_SOCK} (e.g., a docker run or curl command targeting
{TARGET_SOCK}); modify the block where target_name: jamduna and docker_image:
'ghcr.io/jam-duna/duna-target:latest' are defined to add the docker_cmd entry
that uses {TARGET_SOCK}.
In @.github/workflows/jamzig-performance.yml:
- Around line 14-16: The workflow is missing the required docker_cmd input;
update the inputs block (near target_name and docker_image) to add a docker_cmd
entry that explicitly includes the {TARGET_SOCK} placeholder (for example use a
command that mounts or passes the socket to the container and references
{TARGET_SOCK}); ensure the key name is exactly docker_cmd and the value string
includes "{TARGET_SOCK}" so the performance workflow complies with the
.github/workflows/*-performance.yml guideline.
In @.github/workflows/tessera-performance.yml:
- Around line 14-16: The workflow step currently sets only the inputs
target_name and docker_image; you must add the required docker_cmd input and
ensure it includes the {TARGET_SOCK} placeholder. Update the step that defines
inputs (references: target_name and docker_image) to include docker_cmd with a
command string that uses {TARGET_SOCK} (for example a shell command that binds
or references the socket), ensuring the workflow conforms to
.github/workflows/*-performance.yml guidelines and that {TARGET_SOCK} is present
in the docker_cmd value.
In @.github/workflows/tsjam-performance.yml:
- Around line 14-16: Add the missing required input "docker_cmd" to the reusable
workflow call alongside the existing "target_name" and "docker_image" inputs;
set its value to a command string that includes the "{TARGET_SOCK}" placeholder
(e.g., a docker run or dockerd command that references {TARGET_SOCK}) so the
call conforms to the reusable workflow contract expecting docker_cmd containing
{TARGET_SOCK}.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 422b7d5a-78a6-4e72-a1d3-5e10d3c28634
📒 Files selected for processing (14)
.github/workflows/jamduna-fuzz.yml.github/workflows/jamduna-performance.yml.github/workflows/jamzig-fuzz.yml.github/workflows/jamzig-performance.yml.github/workflows/tessera-fuzz.yml.github/workflows/tessera-performance.yml.github/workflows/tsjam-fuzz.yml.github/workflows/tsjam-performance.ymlREADME.mdagents.mdteams/jamduna/.gitkeepteams/jamzig/.gitkeepteams/tessera/.gitkeepteams/tsjam/.gitkeep
These three teams recently switched from GitHub-release binaries to Docker images in davxy/jam-conformance, so they now match the same minimal image-only pattern as the four teams added in the prior commit. Maintainer mentions sourced from the original PRs: jambda (#200), jamixir (#201), spacejam (#202). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tomusdrw
changed the title
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/jambda-performance.yml (1)
14-17:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMissing required
docker_cmdinput for reusable performance workflow.
reusable-picofuzz.ymlis invoked withoutdocker_cmd. This breaks the required per-team workflow contract and also skips the{TARGET_SOCK}placeholder requirement.Suggested patch
jobs: test: uses: ./.github/workflows/reusable-picofuzz.yml with: target_name: jambda docker_image: 'ghcr.io/archelabs/jambda-fuzz-target:latest' + docker_cmd: '<entrypoint args including {TARGET_SOCK}>'As per coding guidelines: required inputs must include
docker_cmd, anddocker_cmdmust contain the{TARGET_SOCK}placeholder.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/jambda-performance.yml around lines 14 - 17, Add the required docker_cmd input to the reusable workflow invocation so it satisfies the per-team contract and includes the {TARGET_SOCK} placeholder; update the workflow block that currently sets target_name: jambda and docker_image: 'ghcr.io/archelabs/jambda-fuzz-target:latest' to also provide a docker_cmd value (for example a command that launches the target inside the container and references {TARGET_SOCK}) so the reusable-picofuzz.yml receives the mandatory docker_cmd containing {TARGET_SOCK}.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/jambda-performance.yml:
- Line 16: The workflow's docker_image setting uses an inaccessible image value
'ghcr.io/archelabs/jambda-fuzz-target:latest' which causes pulls to 404; update
the docker_image key to point to a valid, publicly accessible image (or correct
repository namespace/tag), or push the referenced image to the GHCR registry and
make it public (or configure registry authentication) so the action can pull it;
verify the tag exists and replace the value accordingly in the workflow where
docker_image is defined.
In @.github/workflows/spacejam-performance.yml:
- Around line 14-16: Add the missing required input by adding a docker_cmd entry
to the workflow call alongside target_name and docker_image; ensure the
docker_cmd value includes the socket placeholder {TARGET_SOCK} (e.g., a command
that mounts or references the socket) so the inputs satisfy the per-team
performance workflow contract and the docker_cmd contains the {TARGET_SOCK}
placeholder.
---
Outside diff comments:
In @.github/workflows/jambda-performance.yml:
- Around line 14-17: Add the required docker_cmd input to the reusable workflow
invocation so it satisfies the per-team contract and includes the {TARGET_SOCK}
placeholder; update the workflow block that currently sets target_name: jambda
and docker_image: 'ghcr.io/archelabs/jambda-fuzz-target:latest' to also provide
a docker_cmd value (for example a command that launches the target inside the
container and references {TARGET_SOCK}) so the reusable-picofuzz.yml receives
the mandatory docker_cmd containing {TARGET_SOCK}.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: aa74e960-6bad-4996-8b63-d6da33416be6
📒 Files selected for processing (10)
.github/workflows/jambda-fuzz.yml.github/workflows/jambda-performance.yml.github/workflows/jamixir-fuzz.yml.github/workflows/jamixir-performance.yml.github/workflows/spacejam-fuzz.yml.github/workflows/spacejam-performance.ymlREADME.mdteams/jambda/.gitkeepteams/jamixir/.gitkeepteams/spacejam/.gitkeep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds seven new JAM implementations from
davxy/jam-conformance:scripts/targets.jsonthat ship pure Docker-image targets at gp_version 0.7.2:
ghcr.io/jam-duna/duna-target:latestmkchungsdocker.io/jamzig/jam-conformance-target:latestboymaasghcr.io/chainscore/tessera:latestprasad-kumkarghcr.io/vekexasia/tsjam-target:0.7.2vekexasiaghcr.io/archelabs/jambda-fuzz-target:latestlibingjiang47ghcr.io/jamixir/jamixir:0.7.2danicukiclearloop/spacejam:latestclearloopEach team gets a
*-performance.yml, a*-fuzz.yml, ateams/<team>/.gitkeep, and a row in the README badge table — sameminimal pattern already used for graymatter etc. (image-only, no
docker_cmd, relies on the standardJAM_FUZZ_*env vars).Maintainer mentions sourced from the original PRs/issues on
davxy/jam-conformance.Also drops the stale "Dashboard deploy workflow trigger" step from
agents.md—deploy-dashboard.ymlno longer usesworkflow_run.workflowsand discovers teams dynamically fromteams/*/.Test plan
docker pull --platform=linux/amd64 <image>for all seven*-performance.ymlviaworkflow_dispatchand confirm minifuzz + picofuzz run end-to-end*-fuzz.ymlviaworkflow_dispatchand confirm the demo graymatter source job completesdeploy-dashboard.ymlcron (or manual dispatch)🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
New Features
Documentation