Skip to content

JOTL: increase container memory to 2048m#5

Merged
tomusdrw merged 1 commit intoFluffyLabs:mainfrom
polykrate:jotl-memory
Mar 15, 2026
Merged

JOTL: increase container memory to 2048m#5
tomusdrw merged 1 commit intoFluffyLabs:mainfrom
polykrate:jotl-memory

Conversation

@polykrate
Copy link
Copy Markdown
Contributor

@polykrate polykrate commented Mar 14, 2026

SBCL needs a larger heap for 128 live states (fork support) and bounded GC pauses. The startup script auto-sizes the heap to 75% of the container limit.

Made with Cursor

Summary by CodeRabbit

  • Chores
    • Enhanced performance testing infrastructure by allocating additional memory resources to the Docker environment, enabling more stable and efficient test execution.

SBCL needs a larger heap for 128 live states (fork support) and bounded GC pauses.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cab37ef6-1a8e-401d-89f9-79cb85cc6353

📥 Commits

Reviewing files that changed from the base of the PR and between 8086412 and b00c898.

📒 Files selected for processing (1)
  • .github/workflows/jotl-performance.yml

📝 Walkthrough

Walkthrough

This pull request increases Docker container memory allocation for the reusable-picofuzz workflow in the GitHub Actions performance testing pipeline by adding a docker_memory: '2048m' parameter to the workflow invocation.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/jotl-performance.yml
Added docker_memory: '2048m' input parameter to the reusable-picofuzz workflow invocation to allocate 2GB of memory to the Docker container.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A memory boost hops into view,
Two gigs of RAM for fuzzing through,
The Docker container grows more strong,
Performance tests won't take as long! 💨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: increasing container memory allocation to 2048m in the JOTL workflow configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@polykrate polykrate mentioned this pull request Mar 14, 2026
@tomusdrw
Copy link
Copy Markdown
Member

Just out of curiosity: did you notice any failures, or do you intend to see better perf numbers because of this?

@tomusdrw tomusdrw merged commit 7a5972e into FluffyLabs:main Mar 15, 2026
1 check passed
@polykrate
Copy link
Copy Markdown
Contributor Author

Hello !
No failures, I'm trying to understand why it is so slow, could be ram, or unoptimized garbage collector on the lisp side.

@tomusdrw
Copy link
Copy Markdown
Member

Make sure to take a good look at the test data. AFAICT:

  1. Storage & Storage_tiny should be dominated by PVM execution time / storage host calls.
  2. Safrole is probably dominated by ticket verification
  3. Fallback is probably dominated by signature verification.

Good luck with optimizing!

@coderabbitai coderabbitai Bot mentioned this pull request Mar 17, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants