fix: Primary Number indicator not visible with light theme#290
Merged
naveensingh merged 4 commits intoFossifyOrg:mainfrom Jun 8, 2025
Merged
fix: Primary Number indicator not visible with light theme#290naveensingh merged 4 commits intoFossifyOrg:mainfrom
naveensingh merged 4 commits intoFossifyOrg:mainfrom
Conversation
When the color scheme is set to use a white background color the star icon indicating the default number is drawn in white, making it invisible. The Edit activity explicitly sets the tint for the icon, do it for the View activity as well. Fixes FossifyOrg#289
naveensingh
requested changes
Jun 8, 2025
app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the color scheme is set to use a white background color the star icon indicating the default number is drawn in white, making it invisible. The Edit activity explicitly sets the tint for the icon, do it for the View activity as well.
Fixes #289
Type of change(s)
What changed and why
Fixes the following issue(s)
Checklist
CHANGELOG.md(if applicable).