Skip to content

fix: Primary Number indicator not visible with light theme #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 4 commits into from
Jun 8, 2025
Merged

fix: Primary Number indicator not visible with light theme #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e1cf64
fix: Primary Number indicator not visible with light theme
bluebrother Jun 7, 2025
8cbf4a5
Update Changelog
bluebrother Jun 7, 2025
087f884
Use helper function for setting color
bluebrother Jun 8, 2025
4d8e25c
Update Changelog
bluebrother Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Fixed invisible preferred number indicator in light themes ([#289])

## [1.2.1] - 2025-06-03

### Changed
Expand Down Expand Up @@ -70,3 +74,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#30]: https://github.com/FossifyOrg/Contacts/issues/30
[#201]: https://github.com/FossifyOrg/Contacts/issues/201
[#281]: https://github.com/FossifyOrg/Contacts/issues/281
[#289]: https://github.com/FossifyOrg/Contacts/issues/289
1 change: 1 addition & 0 deletions app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ class ViewContactActivity : ContactActivity() {
}

defaultToggleIcon.isVisible = phoneNumber.isPrimary
defaultToggleIcon.applyColorFilter(getProperTextColor())
}
}
binding.contactNumbersImage.beVisible()
Expand Down
Loading