Skip to content

Disable the addon curation until we're ready#368

Merged
chennes merged 2 commits intoFreeCAD:devfrom
chennes:disableCuratedCache
Mar 26, 2026
Merged

Disable the addon curation until we're ready#368
chennes merged 2 commits intoFreeCAD:devfrom
chennes:disableCuratedCache

Conversation

@chennes
Copy link
Copy Markdown
Member

@chennes chennes commented Mar 25, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 25, 2026 20:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables addon curation gating while the curation feature is not ready, ensuring all catalog entries pass the “approved” filter.

Changes:

  • Alters the approval condition to always include entries (effectively disabling curated-only filtering).
  • Adds an inline comment indicating the curation feature is temporarily disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +166 to +168
if (
entry.curated or True
): # Disable curation until we are ready with the feature
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entry.curated or True is always true, making the condition misleading and easy to forget to remove later. Prefer an explicit feature flag/config (e.g., ENABLE_CURATION = False or an injected setting) with a clear conditional like if not ENABLE_CURATION or entry.curated:; alternatively, if the intent is unconditional approval, remove the if entirely and append directly with a comment explaining the temporary behavior.

Copilot uses AI. Check for mistakes.
@chennes chennes merged commit 0594ebe into FreeCAD:dev Mar 26, 2026
4 of 8 checks passed
@chennes chennes deleted the disableCuratedCache branch March 26, 2026 00:44
@chennes chennes added the release to main Trigger an Action to create a PR backporting to `main` label Mar 26, 2026
@github-actions
Copy link
Copy Markdown

Successfully created backport PR for main:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release to main Trigger an Action to create a PR backporting to `main`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants