Skip to content

Disable the addon curation until we're ready #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chennes merged 2 commits into from
Mar 26, 2026
Merged

Disable the addon curation until we're ready #368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbcc53e
Disable the addon curation until we're ready
chennes Mar 25, 2026
5bd3e07
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion AddonCatalogCacheCreator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ def write(self, addon_id: Optional[str] = None) -> None:
for addon_id, catalog_entries in catalog.items():
approved_entries: List[AddonCatalog.AddonCatalogEntry] = []
for entry in catalog_entries:
if entry.curated:
if (
entry.curated or True
): # Disable curation until we are ready with the feature
Comment on lines +166 to +168
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entry.curated or True is always true, making the condition misleading and easy to forget to remove later. Prefer an explicit feature flag/config (e.g., ENABLE_CURATION = False or an injected setting) with a clear conditional like if not ENABLE_CURATION or entry.curated:; alternatively, if the intent is unconditional approval, remove the if entirely and append directly with a comment explaining the temporary behavior.

Copilot uses AI. Check for mistakes.
approved_entries.append(entry)
if approved_entries:
reduced_catalog[addon_id] = approved_entries
Expand Down
Loading