Skip to content

Pin PySide to 6.10 for now #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chennes merged 1 commit into from
Mar 26, 2026
Merged

Pin PySide to 6.10 for now #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/qt6-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Install Python dependencies
run: |
python -m pip install --upgrade pip
pip install pyfakefs PySide6 vermin requests || true
pip install pyfakefs "PySide6<6.11" vermin requests || true
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description says to pin PySide to 6.10, but the constraint PySide6<6.11 is only an upper bound and could allow older majors/minors if 6.10 wheels aren’t available for a given Python version. If the intent is specifically 6.10.x, consider using a tighter specifier (e.g., PySide6>=6.10,<6.11 or PySide6~=6.10.0) so the workflow can’t silently downgrade.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| true will mask dependency installation failures (including PySide6 resolution issues), which can lead to later, harder-to-diagnose test failures and false confidence in CI. It’s safer to let the step fail on pip install errors, or handle the failure explicitly (e.g., conditionally skip GUI tests when PySide6 can’t be installed for a given matrix entry).

Suggested change
pip install pyfakefs "PySide6<6.11" vermin requests || true
pip install pyfakefs "PySide6<6.11" vermin requests

Copilot uses AI. Check for mistakes.

- name: Run App tests
run: |
Expand Down
Loading