Pin PySide to 6.10 for now#369
Conversation
6.11 was causing the GUI tests to segfault
There was a problem hiding this comment.
Pull request overview
Updates the Qt6 GitHub Actions workflow to constrain the PySide6 version used in CI, aiming to avoid segfaults seen with PySide 6.11 during GUI testing.
Changes:
- Pin PySide6 to
<6.11in the Qt6 tests workflow dependency install step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install pyfakefs PySide6 vermin requests || true | ||
| pip install pyfakefs "PySide6<6.11" vermin requests || true |
There was a problem hiding this comment.
The PR title/description says to pin PySide to 6.10, but the constraint PySide6<6.11 is only an upper bound and could allow older majors/minors if 6.10 wheels aren’t available for a given Python version. If the intent is specifically 6.10.x, consider using a tighter specifier (e.g., PySide6>=6.10,<6.11 or PySide6~=6.10.0) so the workflow can’t silently downgrade.
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install pyfakefs PySide6 vermin requests || true | ||
| pip install pyfakefs "PySide6<6.11" vermin requests || true |
There was a problem hiding this comment.
|| true will mask dependency installation failures (including PySide6 resolution issues), which can lead to later, harder-to-diagnose test failures and false confidence in CI. It’s safer to let the step fail on pip install errors, or handle the failure explicitly (e.g., conditionally skip GUI tests when PySide6 can’t be installed for a given matrix entry).
| pip install pyfakefs "PySide6<6.11" vermin requests || true | |
| pip install pyfakefs "PySide6<6.11" vermin requests |
chennes
added
the
release to main
|
Git push to origin failed for main with exitcode 1 |
6.11 was causing the GUI tests to segfault