[Backport main] Pin PySide<6.11 in CI#371
Conversation
There was a problem hiding this comment.
Pull request overview
Backports CI mitigation for Qt6 GUI test instability by pinning the PySide6 version used in the Qt6 GitHub Actions workflow (per #369, where PySide 6.11 caused segfaults).
Changes:
- Pin PySide6 to
<6.11in the Qt6 tests workflow to avoid the known 6.11 segfault issue. - Modify the Qt6 CI Python version matrix (drops 3.8–3.10 and adds 3.14).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"] | ||
| python-version: ["3.11", "3.12", "3.13", "3.14"] |
There was a problem hiding this comment.
The PR title/description indicates this change is only about pinning PySide6, but this matrix change also drops Python 3.8–3.10 and adds 3.14. If that version/coverage change is intentional, it should be called out in the PR description; otherwise consider reverting the matrix to the prior set of Python versions.
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install pyfakefs PySide6 vermin requests || true | ||
| pip install pyfakefs "PySide6<6.11" vermin requests || true |
There was a problem hiding this comment.
|| true will cause the dependency-install step to succeed even if PySide6<6.11 fails to install, which can turn an install problem into a later, less-informative ImportError/segfault during tests. Consider removing || true (or at least failing the step when PySide6 fails) so CI fails fast with the real error.
| pip install pyfakefs "PySide6<6.11" vermin requests || true | |
| pip install pyfakefs "PySide6<6.11" vermin requests |
chennes
force-pushed
the
pinPySideTo610OnMain
branch
from
e323e0c to
634a389
Compare
chennes
force-pushed
the
pinPySideTo610OnMain
branch
from
634a389 to
6a08921
Compare
Manual backport of #369