Skip to content

[Backport main] Pin PySide<6.11 in CI #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chennes merged 1 commit into from
Mar 26, 2026
Merged

[Backport main] Pin PySide<6.11 in CI #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 0 additions & 59 deletions .github/workflows/qt5-tests.yml
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions .github/workflows/qt6-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ name: Run Qt6 tests

on:
push:
branches: [main]
branches: [dev, main]
pull_request:
branches: [main]
branches: [dev, main]

permissions:
contents: read
Expand All @@ -20,7 +20,7 @@ jobs:

strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.11", "3.12", "3.13", "3.14"]
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description indicates this change is only about pinning PySide6, but this matrix change also drops Python 3.8–3.10 and adds 3.14. If that version/coverage change is intentional, it should be called out in the PR description; otherwise consider reverting the matrix to the prior set of Python versions.

Copilot uses AI. Check for mistakes.

steps:
- name: Checkout repo
Expand Down Expand Up @@ -66,14 +66,14 @@ jobs:
- name: Install Python dependencies
run: |
python -m pip install --upgrade pip
pip install pyfakefs PySide6 vermin requests || true
pip install pyfakefs "PySide6<6.11" vermin requests || true
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| true will cause the dependency-install step to succeed even if PySide6<6.11 fails to install, which can turn an install problem into a later, less-informative ImportError/segfault during tests. Consider removing || true (or at least failing the step when PySide6 fails) so CI fails fast with the real error.

Suggested change
pip install pyfakefs "PySide6<6.11" vermin requests || true
pip install pyfakefs "PySide6<6.11" vermin requests

Copilot uses AI. Check for mistakes.

- name: Run App tests
run: |
python AddonManagerTest/run_app_tests.py

- name: Run GUI tests
env:
QT_QPA_PLATFORM: offscreen
QT_QPA_PLATFORM: xcb
run: |
xvfb-run -s "-screen 0 1920x1080x24" python3 AddonManagerTest/run_gui_tests.py
Loading