Style update of PR #1 and PR # 2 #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S1ngS1ng
added
the
ready for review
|
好的收到 |
wudifeixue
reviewed
Jul 30, 2018
| "description": [ | ||
| "<strong>目标：</strong>使用<a href='https://codepen.io' target='_blank'>CodePen.io</a搭建一个与这个功能上相似的 app：<a href='https://codepen.io/freeCodeCamp/full/VPaoNP' target='_blank'>https://codepen.io/freeCodeCamp/full/VPaoNP</a>。", | ||
| "在满足以下 <a href='https://en.wikipedia.org/wiki/User_story' target='_blank'>user stories</a> 并能通过所有测试的前提下，你可以根据自己的喜好来美化你的 app。", | ||
| "<strong>目标：</strong>使用 <a href='https://codepen.io' target='_blank'>CodePen.io</a> 搭建一个与这个功能上相似的 app：<a href='https://codepen.io/freeCodeCamp/full/VPaoNP' target='_blank'>https://codepen.io/freeCodeCamp/full/VPaoNP</a>。", |
Contributor
Author
There was a problem hiding this comment.
@wudifeixue
空格加不加取决与里面的内容。这一行是英文（半角），下一行是中文（全角）
空格 - 4 - ii
#RTM 🌝
huluoyang
reviewed
Aug 1, 2018
| "description": [ | ||
| "在 package.json 中 version 和 name 是所必填的字段之一。version 字段描述了当前项目的版本。", | ||
| "例子", | ||
| "例子：", |
|
头大，你这个我发现也是存在 |
Contributor
Author
|
@wudifeixue 我记得我改好了几个。。等我回家仔细找一下 |
Contributor
Author
|
@wudifeixue 我两个文件都找了下， |
wudifeixue
approved these changes
Aug 2, 2018
| "<strong>用户故事 10：</strong>对于表单中的名称，邮箱和数字输入框应该使用对应 id 为：<code>id=\"name-label\"</code>、<code>id=\"email-label\"</code>和<code>id=\"number-label\"</code>的描述标签。", | ||
| "<strong>用户故事 11：</strong>在表单中的名称，邮箱和数字输入框中，我能看到各自的描述文字作为占位符。", | ||
| "<strong>用户故事 12：</strong>在表单元素内，我可以在<code>id=\"dropdown\"</code>的下拉列表中选择一个选项。", | ||
| "<strong>用户故事 13：</strong>在表单元素内，我可以从一组或多组单选按钮中选择一个字段。每组使用<code>name</code>属性进行分组。", |
Contributor
Author
|
@wudifeixue 那现在这个也可以 merge 了，没有 conflicts 了 |
S1ngS1ng
added
ship it
SSShooter
pushed a commit
to SSShooter/challenges
that referenced
this pull request
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<code></code>block