GPII-2578: Case-insensitive process matching for Windows.#600
Closed
stegru wants to merge 5 commits intoGPII:masterfrom
Closed
GPII-2578: Case-insensitive process matching for Windows.#600stegru wants to merge 5 commits intoGPII:masterfrom
stegru wants to merge 5 commits intoGPII:masterfrom
Conversation
|
CI job failed: https://ci.gpii.net/job/universal-tests/771/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/772/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/782/ |
klown
approved these changes
Mar 27, 2018
| var commandNameLower = that.options.ignoreCase && commandName.toLowerCase(); | ||
| return fluid.accumulate(procArray, function (aProcInfo, matchingProcs) { | ||
| if (aProcInfo.command === commandName) { | ||
| var match = aProcInfo.command === commandName || |
Member
There was a problem hiding this comment.
Very succinct. Pay no attention to my comment on the other pull request about context awareness. This is the way to do it via a configurable option.
Contributor
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/universal-tests/882/ |
Member
Author
|
closing: merged into #534 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process names are case-insensitive on Windows.
Goes with GPII/windows#169