Skip to content

GPII-2212: Windows Language support#534

Merged
amb26 merged 32 commits intoGPII:masterfrom
stegru:GPII-2212
Aug 7, 2018
Merged

GPII-2212: Windows Language support#534
amb26 merged 32 commits intoGPII:masterfrom
stegru:GPII-2212

Conversation

@stegru
Copy link
Member

@stegru stegru commented Jul 31, 2017

Works well with GPII/windows#132

Changing the language is quite simple (provided the language pack is installed), but getting the applications to react to the change is impossible.

Test with the new "catalina" preference set, which requires the language pack for es-ES, which can be installed via control panel or by downloading it here (Windows 10 build 14393, vm box 2017.07.15). See GPII-2212, "Installing a language".

@gpii-bot
Copy link

gpii-bot commented Jul 31, 2017

CI job passed.

@gpii-bot
Copy link

gpii-bot commented Aug 2, 2017

CI job passed.

@gpii-bot
Copy link

gpii-bot commented Aug 7, 2017

CI job passed.

@stegru
Copy link
Member Author

stegru commented Aug 23, 2017

This isn't quite ready to be merged (but good enough for demoing).

@gpii-bot
Copy link

gpii-bot commented Sep 13, 2017

CI job passed: https://ci.gpii.net/job/universal-tests/482/

@gpii-bot
Copy link

gpii-bot commented Oct 10, 2017

CI job passed: https://ci.gpii.net/job/universal-tests/527/

@gpii-bot
Copy link

gpii-bot commented Dec 11, 2017

CI job passed: https://ci.gpii.net/job/universal-tests/637/

@stegru
Copy link
Member Author

stegru commented Dec 11, 2017

This isn't perfect, as it still applies the language change even if it doesn't need to be changed.

However Gregg would like it in.

@kaspermarkus kaspermarkus requested a review from amb26 December 13, 2017 17:36
@kaspermarkus
Copy link
Member

kaspermarkus commented Dec 13, 2017

@JavierJF will give this pull request a first round of review... Antranig will do the final review and merge

@gpii-bot
Copy link

gpii-bot commented Jan 5, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/652/

@gpii-bot
Copy link

gpii-bot commented Jan 16, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/666/

@stegru
GPII-2212: Made language still work after reboot - added another regi…
38576a6 
…stry location for language change

Also, added "tom" who speaks US English
@gpii-bot
Copy link

gpii-bot commented Jan 26, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/678/

@gpii-bot
Copy link

gpii-bot commented Jun 25, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/920/

@stegru
Merge remote-tracking branch 'upstream/master' into GPII-2212
e24133f 
# Conflicts:
#	tests/data/preferences/os_win7.json5
@gpii-bot
Copy link

gpii-bot commented Jun 26, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/922/

@gpii-bot
Copy link

gpii-bot commented Jun 26, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/923/

@gpii-bot
Copy link

gpii-bot commented Jun 26, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/924/

@stegru stegru mentioned this pull request Jun 26, 2018
Closed
@gpii-bot
Copy link

gpii-bot commented Jul 10, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/942/

@gpii-bot
Copy link

gpii-bot commented Jul 10, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/943/

@stegru stegru removed the Needs Work label Jul 10, 2018
@gpii-bot
Copy link

gpii-bot commented Jul 10, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/944/

@javihernandez
Copy link
Member

javihernandez commented Jul 31, 2018

I've put this on top of master locally and worked great. However, @stegru, would you mind to update this with current master?

@stegru
Copy link
Member Author

stegru commented Jul 31, 2018

👌

@gpii-bot
Copy link

gpii-bot commented Jul 31, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/1006/

@javihernandez
Copy link
Member

javihernandez commented Jul 31, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/1006/

12:53:19.628:  Sending a GET request to: /gpii/_design/views/_view/findClientByOauth2ClientId?key=%22testComputer%22 on port 1234
12:53:20.178:  jq: FAIL: Module "Testing Pouch Manager" Test name "Testing the load and the reset processes" - Message: The response should have a reasonable status code - at sequence position 18 of 20
12:53:20.178:  jq: Expected: 200
12:53:20.178:  jq: Actual: 500
12:53:20.179:  jq: Source:     at Object.assertEquals (/home/vagrant/sync/universal/node_modules/infusion/tests/test-core/jqUnit/js/jqUnit.js:137:19)
    at Object.gpii.test.express.helpers.isSaneResponse (/home/vagrant/sync/universal/node_modules/gpii-pouchdb/node_modules/gpii-express/tests/js/lib/test-helpers.js:28:12)
    at gpii.tests.pouchManager.checkResponse (/home/vagrant/sync/universal/gpii/node_modules/pouchManager/test/pouchManagerTests.js:215:31)
    at togo (/home/vagrant/sync/universal/node_modules/infusion/tests/test-core/utils/js/IoCTestUtils.js:202:33)
    at wrapped (/home/vagrant/sync/universal/node_modules/infusion/tests/test-core/utils/js/IoCTestUtils.js:320:26)
    at fire (/home/vagrant/sync/universal/node_modules/infusion/src/framework/core/js/Fluid.js:1568:40)
    at IncomingMessage.<anonymous> (/home/vagrant/sync/universal/node_modules/kettle/lib/test/KettleTestUtils.http.js:132:13)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.j .... [output suppressed at 1024 chars - for more output, increase fluid.logObjectRenderChars]
"{\"error\":\"OpenError\",\"reason\":\"IO error: /tmp/pouchManagerTests/gpii-mrview-ac9eefd3422f906a613ecb54cb900916/LOCK: No such file or directory\"}\n"
12:53:20.184:  Cleanup error:{
    
}
12:53:20.185:  Database cleanup complete
12:53:20.185:  pouch component error:IO error: /tmp/pouchManagerTests/gpii-mrview-ac9eefd3422f906a613ecb54cb900916/LOCK: No such file or directory

ok to test

@gpii-bot
Copy link

gpii-bot commented Jul 31, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/1007/

amb26
amb26 reviewed Aug 1, 2018
View reviewed changes
gpii/node_modules/processReporter/src/processesBridge.js
* @param {Number} pid - the process id of the process.
* @return {String} - The full path of the process, or null if there's no matching process.
*/
gpii.processes.getProcessPath = function (that, pid) {
Copy link
Member

@amb26 amb26 Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this material end up in this pull? Is it contamination from another pull?

Copy link
Member Author

@stegru stegru Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, GPII/windows#170 (and this one GPII/windows#169).
It's a dependent.

Copy link
Member

@amb26 amb26 Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there must be a universal pull that it came from?

Copy link
Member Author

@stegru stegru Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! wrong repo.

found it: #600

@amb26 amb26 merged commit 959910b into GPII:master Aug 7, 2018
@stepanstipl stepanstipl mentioned this pull request Oct 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amb26 amb26 amb26 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stegru @gpii-bot @kaspermarkus @javihernandez @amb26