GPII-2212: Windows Language support. by stegru · Pull Request #132 · GPII/windows

stegru · 2017-07-31T13:55:57Z

The code in this PR provides a way for a new language to be picked up without having to logout and in to the OS. It restarts explorer (the tasktray) [edited]

edit: Also includes various changes to the process handling to make use of the process reporter (#169)

gpii-bot · 2017-07-31T14:19:13Z

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

gpii-bot · 2017-07-31T14:29:28Z

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

# Conflicts: # package.json

gpii-bot · 2017-08-07T13:49:22Z

CI job passed.

javihernandez · 2017-09-13T13:14:41Z

@stegru can you update this pull request against current master?

# Conflicts: # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # gpii/node_modules/processHandling/processHandling.js # gpii/node_modules/processHandling/test/testProcessHandling.js # package.json

gpii-bot · 2017-09-13T15:16:04Z

CI job failed: https://ci.gpii.net/job/windows-tests/269/

# Conflicts: # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # package.json

gpii-bot · 2017-10-10T15:00:45Z

CI job passed: https://ci.gpii.net/job/windows-tests/301/

gpii-bot · 2017-12-11T11:47:26Z

CI job failed: https://ci.gpii.net/job/windows-tests/337/

stegru · 2017-12-11T11:48:01Z

ok to test

gpii-bot · 2017-12-11T12:11:21Z

CI job passed: https://ci.gpii.net/job/windows-tests/338/

JavierJF · 2018-01-02T16:43:00Z

gpii/node_modules/WindowsUtilities/WindowsUtilities.js

+    ],
+    // https://msdn.microsoft.com/library/aa373344
+    "GetApplicationRestartSettings": [
+        //t.HANDLE, [ t.HANDLE, "char*", t.LPDWORD, t.LPDWORD ]


Is this comment left as a reminder or it's simply a typo?

JavierJF · 2018-01-05T11:25:41Z

gpii/node_modules/processHandling/test/testProcessHandling.js

+        jqUnit.assertFalse("RmShutdown dwSessionHandle must be a number", isNaN(dwSessionHandle));
+        jqUnit.assertEquals(
+            "RmShutdown lActionFlags must be RmShutdownOnlyRegistered", RmShutdownOnlyRegistered, lActionFlags);
+        // For some reason, ref doesn't like being required from this script.


I don't understand this comment, is there a problem with ref? It isn't required right now.

I wanted to check if fnStatus is ref.NULL - but for some reason requiring 'ref' didn't work.

JavierJF · 2018-01-05T11:27:18Z

gpii/node_modules/processHandling/test/testProcessHandling.js

+
+    var rmShutdown = gpii.windows.restartManager.RmShutdown.async;
+    var rmRestart = gpii.windows.restartManager.RmRestart;
+    teardowns.push(function () {


I feel like the fact that adding 'teardowns' to a global from specifics tests just doesn't feel right, doesn't jqUnit has any other alternative for achieving this?

I'm confident there's not another way, otherwise @amb26 would have said something when reviewing the other times I've done this.

I guess an alternative would be to put the teardowns array in gpii.tests.windows.processHandling.

What do you think?

would be great alternative if we could setup an array there for each function. At least will be a fixed pattern that we can follow, with an key based access based on test name maybe.

gpii-bot · 2018-01-05T14:41:08Z

CI job failed: https://ci.gpii.net/job/windows-tests/356/

stegru · 2018-01-05T14:42:13Z

ok to test

gpii-bot · 2018-01-05T15:05:29Z

CI job failed: https://ci.gpii.net/job/windows-tests/357/

JavierJF · 2018-01-09T11:01:01Z

gpii/node_modules/processHandling/test/testProcessHandling.js

+jqUnit.asyncTest("Test restartProcesses", function () {
+    jqUnit.expect(2);
+
+    // Windows explorer does register as restartable, but restarting it (and potentially failing, because it's a test)


I'm doing the same exact thing here. Did you found any trouble restarting the explorer or do you thought that was simply excessive for a test?

After talking, we can assume that as these are direct third party API calls that are being mocked, and that we are testing nothing more than that, we can assume that the API is working if it's properly called. If that isn't the case, then the problem isn't on our end.

JavierJF · 2018-01-09T11:37:01Z

This PR looks good to me. It should receive another review from @javihernandez or @amb26 for example in order to receive approval.

Completed array to string change.

GPII-2212: Fixed tests execution

gpii-bot · 2018-01-13T12:10:51Z

CI job passed: https://ci.gpii.net/job/windows-tests/362/

# Conflicts: # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # gpii/node_modules/processHandling/processHandling.js # gpii/node_modules/processHandling/test/testProcessHandling.js # package.json

gpii-bot · 2018-04-02T14:13:33Z

CI job passed: https://ci.gpii.net/job/windows-tests/442/

gpii-bot · 2018-04-04T12:25:12Z

CI job failed: https://ci.gpii.net/job/windows-tests/448/

stegru · 2018-04-04T12:40:35Z

updated universal.. ok to test

gpii-bot · 2018-04-04T13:02:22Z

CI job passed: https://ci.gpii.net/job/windows-tests/449/

# Conflicts: # README.md # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # package.json

gpii-bot · 2018-06-25T15:03:06Z

CI job failed: https://ci.gpii.net/job/windows-tests/556/

gpii-bot · 2018-06-25T16:25:21Z

CI job failed: https://ci.gpii.net/job/windows-tests/559/

# Conflicts: # gpii/node_modules/processHandling/test/test-window.c # package.json

gpii-bot · 2018-06-26T10:14:12Z

CI job passed: https://ci.gpii.net/job/windows-tests/560/

…nged.

gpii-bot · 2018-07-10T13:21:43Z

CI job failed: https://ci.gpii.net/job/windows-tests/572/

stegru · 2018-07-10T16:00:15Z

ok to test

    default: ERROR: Running ["C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat Text -OutputFormat Text -EncodedCommand <bullshit>] was not successful. Exit code was '1'. See log for possible error messages.
    default: The install of dotnet3.5 was NOT successful.
    default: Error while running 'C:\ProgramData\chocolatey\lib\DotNet3.5\Tools\ChocolateyInstall.ps1'.
    default:  See log for details.
    default: wixtoolset v3.11.1 [Approved]
    default: wixtoolset package files install completed. Performing other installation steps.
    default: Installing wixtoolset...
Build was aborted
Aborted by unknown
Finished: ABORTED

gpii-bot · 2018-07-10T16:29:48Z

CI job passed: https://ci.gpii.net/job/windows-tests/573/

# Conflicts: # package.json

javihernandez · 2018-07-31T12:35:57Z

I've already tested this on top of current universal and windows and worked great. 👍
As with the universal side of this pr, @stegru can you update it with current master? After that, @amb26 do you mind taking a look at this one? It would be great to deliver this along with the QSS.

gpii-bot · 2018-07-31T13:20:52Z

CI job failed: https://ci.gpii.net/job/windows-tests/596/

javihernandez · 2018-07-31T13:45:27Z

CI job failed: https://ci.gpii.net/job/windows-tests/596/

05:53:29.123: jq: FAIL: Module "gpii.tests.acceptance.windows.builtIn.config tests" Test name "Testing os_common using default matchmaker" - Message: Error making request to /user/os_common/login: socket hang up

ok to test

gpii-bot · 2018-07-31T14:08:50Z

CI job passed: https://ci.gpii.net/job/windows-tests/597/

stegru added 2 commits July 31, 2017 14:00

GPII-2212: Added restart/shutdown applications

a1f4b22

GPII-2212: Pointing universal to the branch that works with this.

24ba1f9

stegru mentioned this pull request Jul 31, 2017

GPII-2212: Windows Language support GPII/universal#534

Merged

GPII-2495: Made SPI tests work again.

e4320c8

Merge remote-tracking branch 'upstream/master' into GPII-2212

c99a350

# Conflicts: # package.json

Merge remote-tracking branch 'upstream/master' into GPII-2212

d281be9

# Conflicts: # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # gpii/node_modules/processHandling/processHandling.js # gpii/node_modules/processHandling/test/testProcessHandling.js # package.json

Merge remote-tracking branch 'upstream/master' into GPII-2212

2a2ffc8

# Conflicts: # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # package.json

Merge remote-tracking branch 'upstream/master' into GPII-2212

575a912

JavierJF reviewed Jan 2, 2018

View reviewed changes

JavierJF reviewed Jan 5, 2018

View reviewed changes

GPII-2212: MAde the teardowns global a member of the test module

6227913

JavierJF reviewed Jan 9, 2018

View reviewed changes

JavierJF and others added 3 commits January 12, 2018 18:41

GPII-2212: Fixed tests execution

733c0e7

GPII-2212

473b62c

Completed array to string change.

Merge pull request #1 from JavierJF/GPII-2212

f524f24

GPII-2212: Fixed tests execution

stegru added 3 commits March 28, 2018 14:04

TESTING

7a65d26

Merge branch 'GPII-2844' into GPII-2212

1a45817

# Conflicts: # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # gpii/node_modules/processHandling/processHandling.js # gpii/node_modules/processHandling/test/testProcessHandling.js # package.json

Merge branch 'master' into GPII-2212

49fd0c5

stegru added 3 commits April 4, 2018 12:35

GPII-2844: No change

3840fde

Merge branch 'GPII-2844' into GPII-2212

a4a5f6e

GPII-2212: Corrected universal reference

e35319e

stegru added 3 commits June 20, 2018 14:41

Merge remote-tracking branch 'upstream/master' into GPII-2212

f7851d3

# Conflicts: # README.md # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # package.json

GPII-2844: Comment improvements.

c27f00c

GPII-2212: Restart explorer after language setting.

0eb54da

GPII-2212: Made AT unit test use appropriate process detection.

3a5d1ce

stegru added 2 commits June 25, 2018 18:14

Merge remote-tracking branch 'upstream/master' into GPII-2212

cd4332b

# Conflicts: # gpii/node_modules/processHandling/test/test-window.c # package.json

GPII-2212: Fixed win32 error reporting.

b38f1f1

stegru added 2 commits July 10, 2018 13:26

GPII-2212: Nice hack to only restart explorer if the language has cha…

cd8cb93

…nged.

Merge remote-tracking branch 'upstream/master' into GPII-2212

6e4ebf3

Merge remote-tracking branch 'upstream/master' into GPII-2212

5dffa9f

# Conflicts: # package.json

amb26 merged commit 5dffa9f into GPII:master Aug 7, 2018

Conversation

stegru commented Jul 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpii-bot commented Jul 31, 2017

Uh oh!

gpii-bot commented Jul 31, 2017

Uh oh!

gpii-bot commented Aug 7, 2017

Uh oh!

javihernandez commented Sep 13, 2017

Uh oh!

gpii-bot commented Sep 13, 2017

Uh oh!

gpii-bot commented Oct 10, 2017

Uh oh!

gpii-bot commented Dec 11, 2017

Uh oh!

stegru commented Dec 11, 2017

Uh oh!

gpii-bot commented Dec 11, 2017

Uh oh!

JavierJF Jan 2, 2018

Choose a reason for hiding this comment

Uh oh!

JavierJF Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

stegru Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

JavierJF Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

stegru Jan 5, 2018

Choose a reason for hiding this comment

Uh oh!

JavierJF Jan 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gpii-bot commented Jan 5, 2018

Uh oh!

stegru commented Jan 5, 2018

Uh oh!

gpii-bot commented Jan 5, 2018

Uh oh!

JavierJF Jan 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JavierJF Jan 9, 2018

Choose a reason for hiding this comment

Uh oh!

JavierJF commented Jan 9, 2018

Uh oh!

gpii-bot commented Jan 13, 2018

Uh oh!

gpii-bot commented Apr 2, 2018

Uh oh!

gpii-bot commented Apr 4, 2018

Uh oh!

stegru commented Apr 4, 2018

Uh oh!

gpii-bot commented Apr 4, 2018

Uh oh!

gpii-bot commented Jun 25, 2018

Uh oh!

gpii-bot commented Jun 25, 2018

Uh oh!

gpii-bot commented Jun 26, 2018

Uh oh!

gpii-bot commented Jul 10, 2018

Uh oh!

stegru commented Jul 10, 2018

Uh oh!

gpii-bot commented Jul 10, 2018

Uh oh!

javihernandez commented Jul 31, 2018

Uh oh!

stegru commented Jul 31, 2017 •

edited

Loading

JavierJF Jan 5, 2018 •

edited

Loading

JavierJF Jan 9, 2018 •

edited

Loading