Recompilation fix #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=========================================
+ Coverage 99.79% 99.8% +<.01%
=========================================
Files 17 17
Lines 994 1013 +19
=========================================
+ Hits 992 1011 +19
Misses 2 2
Continue to review full report at Codecov.
|
icouckuy
reviewed
Aug 22, 2017
GPflowOpt/scaling.py
Outdated
| :param t: :class:`.DataTransform` object: the new input transform. | ||
| """ | ||
| assert(isinstance(t, DataTransform)) | ||
| assert (isinstance(t, DataTransform)) |
Merged
icouckuy
approved these changes
Aug 23, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in GPflow/GPflow#442, a fix was developed to solve the recompilation problems which cause e.g. #37, which is the only known incompatibility between the GPflowOpt design and GPflow. The reason for this might be solved in the future in GPflow itself, which should be preferred over this solution.