feat(Store,Reservation): 예약 많은/적은순 정렬 로직 개

[HyemIin]

작업 요약

• 최대 5개 store만 호출
• waitingUserRsponse에 reservationId 추가

Issue Link

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 버그 수정

  • 대기자 정보 조회 시 사용자 닉네임, 예약 생성 시간, 예약 ID를 보다 정확하게 반환하도록 개선되었습니다.

• 기능 개선

  • 매장별 대기 인원 순으로 상위 5개 매장만 보여주도록 목록이 제한되었습니다.

[coderabbitai]

Walkthrough

이 변경사항은 두 서비스 클래스의 내부 메서드 로직을 개선한 것입니다. ReservationService에서는 대기 사용자 상세 정보를 조회할 때 데이터베이스 쿼리를 하나로 통합했고, StoreServiceImpl에서는 대기 인원 기준으로 정렬된 상위 5개 매장만 반환하도록 변경되었습니다. 외부 인터페이스 시그니처에는 변경이 없습니다.

Changes

파일 경로	변경 요약
.../reservation/service/ReservationService.java	대기 사용자 상세 조회 시 사용자 닉네임과 예약 정보를 단일 쿼리로 통합, 불필요한 import 제거
.../store/service/StoreServiceImpl.java	대기 인원순 매장 조회 시 상위 5개만 반환하도록 제한

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat(Order,Reservation): 주문 조회 응답 데이터 개선 및 대기열 CRUD 구현 #140: ReservationService의 대기 사용자 및 예약 관리 로직과 WaitingUserResponse DTO 개선, 데이터베이스 쿼리 통합 등 본 PR의 ReservationService 관련 변경과 직접적으로 연관됨.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/#147-store대기인원순정렬

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/reservation/service/ReservationService.java (1)

122-122: 불필요한 빈 줄을 제거하세요.

-

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4ab742 and af7be08.

📒 Files selected for processing (2)

• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/reservation/service/ReservationService.java (3 hunks)
• nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/service/StoreServiceImpl.java (1 hunks)

🔇 Additional comments (3)

nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/service/StoreServiceImpl.java (1)

246-248: 상위 5개 매장 제한 로직이 올바르게 구현되었습니다.

정렬 후 .limit(5)를 적용하여 대기 인원 기준으로 상위 5개 매장만 반환하도록 변경된 것이 PR 목표와 일치합니다.

nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/reservation/service/ReservationService.java (2)

98-109: 데이터베이스 쿼리 최적화 및 reservationId 추가가 잘 구현되었습니다.

단일 쿼리를 사용하여 사용자 정보와 예약 정보를 함께 조회하도록 개선되었고, PR 목표에 따라 reservationId가 응답에 포함되었습니다. Optional 처리를 통해 예약이 존재하지 않는 경우도 안전하게 처리됩니다.

---

112-112: reservationId가 응답 객체에 올바르게 추가되었습니다.

null 체크를 통해 reservationId를 문자열로 변환하거나 null을 반환하는 로직이 적절합니다.