fix(Reservation): NonUniqueResultException 문제 해결

[Jjiggu]

작업 요약

NonUniqueResultException 문제 해결

Issue Link

#166

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 버그 수정
  • 대기 사용자별로 당일 가장 최근 예약 정보만 조회하도록 개선되었습니다.
• 기타
  • 일부 내부 쿼리 동작에 대한 개선 사항이 반영되었습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

ReservationService의 getAllWaitingUserDetails(Long storeId) 메서드에서 N+1 쿼리 문제에 대한 TODO 주석이 추가되고, 각 유저별 예약 조회 쿼리가 최신 예약 1건만 반환하도록 변경되었습니다. ReservationRepository에는 해당 쿼리를 위한 새로운 메서드가 추가되었습니다.

Changes

파일/경로	변경 요약
.../reservation/service/ReservationService.java	N+1 쿼리 문제에 대한 TODO 주석 추가, 유저별 예약 조회 쿼리를 최신 1건만 반환하도록 메서드 변경
.../reservation/repository/ReservationRepository.java	최신 예약 1건만 반환하는 findFirstByStore_StoreIdAndUserIdAndRequestedAtBetweenOrderByRequestedAtDesc 메서드 추가

Sequence Diagram(s)

sequenceDiagram
    participant AdminAPI as ReservationService
    participant Repo as ReservationRepository
    participant DB as Database

    AdminAPI->>Repo: getAllWaitingUserDetails(storeId)
    loop 각 대기 유저에 대해
        AdminAPI->>Repo: findFirstByStore_StoreIdAndUserIdAndRequestedAtBetweenOrderByRequestedAtDesc(...)
        Repo->>DB: SELECT ... ORDER BY requested_at DESC LIMIT 1
        DB-->>Repo: Reservation (Optional)
        Repo-->>AdminAPI: Reservation (Optional)
    end
    AdminAPI-->>AdminAPI: 결과 리스트 생성

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat(Store,Reservation): 예약 많은/적은순 정렬 로직 개 #152: ReservationService의 getAllWaitingUserDetails 메서드의 예약 데이터 조회 로직 개선과 관련된 변경이 있습니다.
• feat(Reservation):예약 리스트 조회 로직 개선 #165: getAllWaitingUserDetails 메서드와 ReservationRepository의 쿼리 메서드 추가/변경 등 예약 조회 로직 개선이 직접적으로 연관되어 있습니다.
• feat(Order,Reservation): 주문 조회 응답 데이터 개선 및 대기열 CRUD 구현 #140: 서비스와 저장소 계층에서 대기 유저 상세 및 예약 쿼리 관련 로직을 개선한 점에서 직접적인 코드 레벨 연관성이 있습니다.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4742725 and bdf3e5e.

📒 Files selected for processing (2)

• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/reservation/service/ReservationService.java (2 hunks)
• nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/reservation/repository/ReservationRepository.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix#166-fix-NonUniqueResultException

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.