Refoctor: admin 전용 메뉴 이름 추가

[Jjiggu]

작업 요약

• 주문 조회 시 어드민 메뉴 이름으로 노출되도록 변경
• 로그인 시 response에 storeId 필드 추가

Issue Link

#250

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 새로운 기능

  • 매니저 로그인 응답에 주점 ID(storeId) 정보가 추가되었습니다.

• 버그 수정

  • 주문 응답에서 메뉴 상세 항목이 관리자용 메뉴명 기준으로 그룹화되도록 개선되었습니다.

• 문서

  • 주문 리스트 조회 관련 API의 설명 문구가 더 명확하게 수정되었습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

이 변경사항은 Swagger/OpenAPI 문서의 한글 표현을 개선하고, 주문 응답 DTO의 메뉴 그룹핑 키를 관리자용 표시명으로 변경하며, 매니저 로그인 응답 DTO에 storeId 필드를 추가하는 등, API 응답 데이터와 문서화의 정확성을 높이기 위한 내부 로직 및 어노테이션 수정을 포함합니다.

Changes

Cohort / File(s)	Change Summary
OrderController 문서화 개선 nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/controller/OrderController.java	Swagger/OpenAPI의 getOrderListByStoreId 메소드의 summary와 description 한글 표현을 명확하게 수정함. 기능 로직에는 영향 없음.
OrderResponseDto 메뉴 그룹핑 키 변경 nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/dto/OrderResponseDto.java	fromEntity 메소드에서 메뉴 아이템 그룹핑 키를 기존의 menu.getName()에서 menu.getAdminDisplayName()으로 변경하여 관리자 표시명을 기준으로 메뉴를 집계하도록 수정함.
ManagerLoginResponseDto 필드 추가 nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/user/dto/ManagerLoginResponseDto.java	storeId 필드(Long 타입)와 Swagger 어노테이션을 추가하고, fromEntity 정적 팩토리 메소드가 user.getStoreId()로 해당 필드를 세팅하도록 변경함.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant OrderController
    participant OrderResponseDto
    participant User
    participant ManagerLoginResponseDto

    Client->>OrderController: getOrderListByStoreId(storeId)
    OrderController->>OrderResponseDto: fromEntity(userOrder)
    OrderResponseDto->>OrderResponseDto: 메뉴를 adminDisplayName 기준으로 그룹핑
    OrderController-->>Client: 주문 리스트 반환

    Client->>ManagerLoginResponseDto: 로그인 요청
    ManagerLoginResponseDto->>User: getStoreId()
    ManagerLoginResponseDto-->>Client: storeId 포함 응답 반환

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Refoctor: 관리자용 메뉴 이름 추가 #251: OrderResponseDto.fromEntity에서 menu.getAdminDisplayName() 사용 관련 필드 및 DTO 변경이 직접적으로 연관됨.
• feat(Order): order 조회 칼럼 추가 #68: OrderResponseDto.fromEntity의 메뉴 아이템 집계 로직을 수정하는 등, 내부 집계 및 필드 추가와 관련된 변경점이 있음.
• refactor(order): 주문 내역 리스트 반환 값 수정 #246: OrderResponseDto.fromEntity에서 메뉴 상세 구조 및 집계 로직을 변경한 PR로, 동일 메소드의 내부 로직 수정과 관련됨.

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 460373b and 381a1da.

📒 Files selected for processing (3)

• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/controller/OrderController.java (1 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/dto/OrderResponseDto.java (1 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/user/dto/ManagerLoginResponseDto.java (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refoctor#250-admin-menuName

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.