Skip to content

Conversation

@HyemIin
Copy link
Member

@HyemIin HyemIin commented Jul 8, 2025

작업 요약

  • 메뉴명 & 수량 추가

Issue Link

#67

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 신규 기능

    • 주문 응답에 메뉴 이름과 수량의 집계 정보를 추가하였습니다.
  • 버그 수정

    • 주문 목록 조회 시, 존재하지 않는 매장일 경우 오류 메시지를 표시하도록 개선하였습니다.

- 메뉴명 & 수량 추가
@HyemIin HyemIin self-assigned this Jul 8, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 8, 2025

"""

Walkthrough

OrderResponseDto 클래스에 메뉴 이름과 수량을 집계하는 필드가 추가되고, OrderService 클래스에서는 storeId로 매장 존재 여부를 확인하는 검증 로직이 추가되었습니다. 이에 따라 관련 메서드와 의존성 주입이 수정되었습니다.

Changes

파일/경로 변경 요약
.../order/dto/OrderResponseDto.java 메뉴 이름-수량 Map 필드 추가, fromEntity 메서드에 집계 로직 추가
.../order/service/OrderService.java StoreRepository 의존성 추가, findAllOrders에 매장 존재 검증 로직 추가

Suggested reviewers

  • Jjiggu
    """

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between baad7ff and 7e65302.

📒 Files selected for processing (1)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/service/OrderService.java (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/service/OrderService.java
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from Jjiggu July 8, 2025 05:15
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 981309e and baad7ff.

📒 Files selected for processing (2)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/dto/OrderResponseDto.java (2 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/service/OrderService.java (2 hunks)
🔇 Additional comments (6)
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/service/OrderService.java (2)

12-14: 필요한 import 문들이 적절히 추가되었습니다.

새로운 메뉴 검증 기능을 위한 import 문들이 올바르게 추가되었습니다.


33-33: MenuRepository 의존성 주입이 올바르게 추가되었습니다.

Spring의 표준 의존성 주입 패턴을 따라 MenuRepository가 적절히 주입되었습니다.

nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/order/dto/OrderResponseDto.java (4)

4-8: 필요한 import 문들이 적절히 추가되었습니다.

새로운 컬렉션 처리 기능을 위한 import 문들이 올바르게 추가되었습니다.


23-23: 메뉴 이름과 수량을 위한 필드가 적절히 추가되었습니다.

PR 목표에 부합하는 menuNamesAndQuantities 필드가 Map<String, Integer> 타입으로 적절히 정의되었습니다.


27-32: 메뉴 이름과 수량 집계 로직이 훌륭하게 구현되었습니다.

Stream API를 사용하여 주문 항목들을 메뉴명별로 그룹화하고 수량을 합산하는 로직이 매우 잘 구현되었습니다. 특히 Integer::sum을 사용하여 중복 메뉴명의 수량을 합치는 처리가 우수합니다.


40-40: 빌더에 새 필드가 올바르게 추가되었습니다.

새로운 menuNamesAndQuantities 필드가 빌더 패턴에 적절히 추가되어 DTO 구성을 완료했습니다.

- 메뉴명 & 수량 추가
@HyemIin HyemIin merged commit a68a42f into develop Jul 8, 2025
1 check passed
@HyemIin HyemIin deleted the feature/#67-order조회칼럼변경 branch July 8, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants