Feature/15 login by nathcouret · Pull Request #187 · GameTactic/Room

nathcouret · 2020-04-23T19:51:53Z

No description provided.

src/store/modules/authentication.ts

src/views/Login.vue

src/components/navigation/LoginCard.vue

src/components/navigation/LoginDialog.vue

src/components/navigation/TheUserMenu.vue

src/views/Login.vue

NikoGrano · 2020-04-23T20:14:24Z

I think the providers data should be fetched from the microservice, rather than hardcoding it into the app.

Eirmas

Good work! Just remove the console logs so that the pipeline check succeeds, and do the other changes that Sam and Niko requested :)

NikoGrano

Please resolve conversations

NikoGrano

Looks good. Just run eslint --fix or fix manually errors specified here.

bryansamuel1

Quite surprised the build has failed on so many es-lint issues, doesn't your local compiler warn you of this while you are running "Yarn Serve"?

Anyway fix them please without using eslint-disable line if possible :)

Good work, just some tidying up and renaming to go

src/components/navigation/LoginCard.vue

src/components/navigation/TheUserMenu.vue

src/util/ProvidersUtil.ts

src/util/TypeUtils.ts

NikoGrano · 2020-05-03T08:43:57Z

@bryansamuel1 Why does this PR contain also translations?

NikoGrano

Please fix the bug you mentioned.
@bryansamuel1 Why are translations in this PR? Please create PR for them and open PR for them into develop. After that is merged into develop can this be reviewed again and possibly merged.

bryansamuel1 · 2020-05-03T09:15:46Z

@Ataww @NikoGrano @Eirmas This PR was created as a merge into MASTER not DEVELOP.
I have changed it to DEVELOP now so please re PR / check

NikoGrano · 2020-05-03T09:16:55Z

Oh, thanks!

@Ataww Please take note and resolve conflicts.

src/App.vue

NikoGrano · 2020-05-06T13:12:12Z

Please also note #199 in this PR.

NikoGrano · 2020-05-06T13:31:49Z

Also note #200

NikoGrano · 2020-05-06T13:44:20Z

I added documentation to README.md of authentication microservice in 406114d8. Feel free check that out, I dont want paste everything here.

Information is related in both #199 and #200.

nathcouret · 2020-05-06T13:45:05Z

I added documentation to README.md of authentication microservice in 406114d8. Feel free check that out, I dont want paste everything here.

Information is related in both #199 and #200.

Will do thanks

# Conflicts: # src/App.vue # src/components/navigation/LoginCard.vue # src/components/navigation/TheUserMenu.vue # src/store/modules/authentication.ts

# Conflicts: # src/App.vue # src/plugins/vuetify.ts # src/types/Canvas.ts # src/types/Games/Wows.ts

NikoGrano · 2020-05-17T11:23:04Z

@Ataww Would you mind update us with the status 😛

bryansamuel1

Almost there! Some simple syntax and styling changes + a couple of translations. Final push for victory!

src/App.vue

src/components/navigation/LoginCard.vue

src/components/navigation/login/ProviderBlock.vue

src/store/modules/authentication.ts

bryansamuel1 · 2020-05-26T07:23:03Z

@NikoGrano can you squash and merge this into dev please?

src/components/navigation/login/ProviderBlock.vue

NikoGrano

Requested changes will be done as additional PR.

bryansamuel1 · 2020-05-26T14:51:41Z

Wooo finally merged!!!

NikoGrano · 2020-05-26T14:51:42Z

Used administrator privileges to merge this due unsigned commits.

nathcouret added 4 commits April 7, 2020 19:39

#15 - Refactored navbar component

f3fe7e1

Merge remote-tracking branch 'origin/develop' into feature/15-login

2de344e

#15 - Login card with auth token in local storage

869851f

Merge remote-tracking branch 'origin/develop' into feature/15-login

428e617

nathcouret requested review from Eirmas, NikoGrano and bryansamuel1 April 23, 2020 19:51

NikoGrano reviewed Apr 23, 2020

View reviewed changes

src/store/modules/authentication.ts Show resolved Hide resolved

NikoGrano reviewed Apr 23, 2020

View reviewed changes

src/store/modules/authentication.ts Outdated Show resolved Hide resolved

NikoGrano reviewed Apr 23, 2020

View reviewed changes

src/views/Login.vue Outdated Show resolved Hide resolved

#15 - remove legacy login page

0e6ab86

nathcouret force-pushed the feature/15-login branch from 16bf670 to 0e6ab86 Compare April 23, 2020 20:01

bryansamuel1 reviewed Apr 23, 2020

View reviewed changes

Eirmas previously approved these changes Apr 23, 2020

View reviewed changes

NikoGrano requested changes Apr 25, 2020

View reviewed changes

#15 - Add login providers from auth uservice

eb556ef

nathcouret dismissed Eirmas’s stale review via eb556ef April 26, 2020 15:33

NikoGrano requested a review from bryansamuel1 April 27, 2020 21:08

NikoGrano added the enhancement New feature or request label Apr 27, 2020

NikoGrano linked an issue Apr 27, 2020 that may be closed by this pull request

MVP1 - User - Sign In #15

Open

1 task

NikoGrano requested changes Apr 27, 2020

View reviewed changes

bryansamuel1 suggested changes Apr 28, 2020

View reviewed changes

nathcouret added 2 commits May 2, 2020 20:07

Merge remote-tracking branch 'origin/develop' into feature/15-login

786aad1

#15 - improve login dialog design

6359460

NikoGrano requested changes May 3, 2020

View reviewed changes

bryansamuel1 changed the base branch from master to develop May 3, 2020 09:15

bryansamuel1 reviewed May 3, 2020

View reviewed changes

src/App.vue Show resolved Hide resolved

nathcouret added 2 commits May 14, 2020 20:40

Merge remote-tracking branch 'origin/develop' into feature/15-login

1709e4e

# Conflicts: # src/App.vue # src/components/navigation/LoginCard.vue # src/components/navigation/TheUserMenu.vue # src/store/modules/authentication.ts

Merge remote-tracking branch 'origin/develop' into feature/15-login

1f889ab

# Conflicts: # src/App.vue # src/plugins/vuetify.ts # src/types/Canvas.ts # src/types/Games/Wows.ts

nathcouret added 2 commits May 17, 2020 20:32

Login dialog gaps

a4efb91

Add translations

c3f9383

bryansamuel1 added this to the 0.1.0 milestone May 23, 2020

nathcouret added 2 commits May 24, 2020 20:53

Merge remote-tracking branch 'origin/develop' into feature/15-login

b6521c1

feature/15 - closeable login dialog on mobile

35ae7e8

bryansamuel1 suggested changes May 24, 2020

View reviewed changes

PR feedbacks

b2850c5

bryansamuel1 approved these changes May 26, 2020

View reviewed changes

NikoGrano requested changes May 26, 2020

View reviewed changes

src/components/navigation/login/ProviderBlock.vue Show resolved Hide resolved

NikoGrano approved these changes May 26, 2020

View reviewed changes

NikoGrano merged commit 2b18161 into develop May 26, 2020

NikoGrano deleted the feature/15-login branch May 26, 2020 14:51

This was referenced May 26, 2020

Handle authentication error #199

Open

Auhentication refresh token #200

Closed

Feature/207 set up state for sockets #208

Merged

Uh oh!

Conversation

nathcouret commented Apr 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NikoGrano commented Apr 23, 2020

Uh oh!

Eirmas left a comment

Choose a reason for hiding this comment

Uh oh!

NikoGrano left a comment

Choose a reason for hiding this comment

Uh oh!

NikoGrano left a comment

Choose a reason for hiding this comment

Uh oh!

bryansamuel1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NikoGrano commented May 3, 2020

Uh oh!

NikoGrano left a comment

Choose a reason for hiding this comment

Uh oh!

bryansamuel1 commented May 3, 2020

Uh oh!

NikoGrano commented May 3, 2020

Uh oh!

Uh oh!

NikoGrano commented May 6, 2020

Uh oh!

NikoGrano commented May 6, 2020

Uh oh!

NikoGrano commented May 6, 2020

Uh oh!

nathcouret commented May 6, 2020

Uh oh!

NikoGrano commented May 17, 2020

Uh oh!

bryansamuel1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bryansamuel1 commented May 26, 2020

Uh oh!

Uh oh!

NikoGrano left a comment

Choose a reason for hiding this comment

Uh oh!