Skip to content

Feature/207 set up state for sockets#208

Merged
bryansamuel1 merged 2 commits intodevelopfrom
feature/207-SetUpStateForSockets
May 27, 2020
Merged

Feature/207 set up state for sockets#208
bryansamuel1 merged 2 commits intodevelopfrom
feature/207-SetUpStateForSockets

Conversation

@bryansamuel1
Copy link
Contributor

@bryansamuel1 bryansamuel1 commented May 25, 2020

Work Completed

  1. Add namespaces to all files that use the store, replacing any hardcoded namespaces with an enum
  2. Split the store modules in two. The app module contains all the modules that have state that is not shared via the sockets. The socket module contains all the modules that have state that is shared via the sockets.
  3. Move data that is stored in the @component data object into the class so it is a class property. This makes it consistent throughout the app
  4. Rename some components so they following the naming convention of the app. Components that are only used once are now prepended with The (TheIndex, TheRoom) etc.
  5. Cleaned up some of the formatting throughout the app so indentation is consistent and spacing between classes is consistent

@bryansamuel1 bryansamuel1 changed the base branch from master to develop May 25, 2020 10:33
Copy link
Member

@Eirmas Eirmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and efficient work :)
We could also use namespaces inside the modules for the mutations and actions and all that

@bryansamuel1
Copy link
Contributor Author

Good and efficient work :)
We could also use namespaces inside the modules for the mutations and actions and all that

I could do that now it shouldn't take me long

@bryansamuel1 bryansamuel1 force-pushed the feature/207-SetUpStateForSockets branch from 30f43bf to fd14e95 Compare May 26, 2020 17:30
@bryansamuel1
Copy link
Contributor Author

Good and efficient work :)
We could also use namespaces inside the modules for the mutations and actions and all that

I could do that now it shouldn't take me long

I'll do it in another PR. This one is large enough

@bryansamuel1
Copy link
Contributor Author

With my latest commit I have also done the following

  1. Changed the disabled colour for the entity panel to the same colour as the nav
  2. Put a button saying "Login" instead of the menu dropdown. If they are logged in then the menu drop down will show as normal
  3. Tidied up some of the code from Nath PR just to tie in with the rest of the clean up and refactoring that I have done in this PR
  4. Fix PR comment from Eirmas
  5. Made the provider PascalCase with spaces instead of lowercase (asked by @NikoGrano previously)

@bryansamuel1
Copy link
Contributor Author

Here is the new Login button for the nav
image

@bryansamuel1 bryansamuel1 requested a review from Eirmas May 26, 2020 17:48
@NikoGrano
Copy link
Member

Please check always preview!

@NikoGrano
Copy link
Member

There is one thing missing from #187.

When user has logged in, the GET parameter code should be removed from url to prevent users copying the url and giving it to somebody else as "please join room via this link".

In that case they would also give their session to that user....

@bryansamuel1 bryansamuel1 added enhancement New feature or request frontend Frontend related labels May 26, 2020
@bryansamuel1 bryansamuel1 self-assigned this May 26, 2020
@bryansamuel1
Copy link
Contributor Author

Please check always preview!

You wha?

@bryansamuel1
Copy link
Contributor Author

There is one thing missing from #187.

When user has logged in, the GET parameter code should be removed from url to prevent users copying the url and giving it to somebody else as "please join room via this link".

In that case they would also give their session to that user....

agreed. I will do that as part of this PR

@NikoGrano
Copy link
Member

Please check always preview!

You wha?

Branch has always preview environment. ;) You dont have to screenshot.

@bryansamuel1
Copy link
Contributor Author

Please check always preview!

You wha?

Branch has always preview environment. ;) You dont have to screenshot.

how does one look at it?

@NikoGrano
Copy link
Member

Please check always preview!

You wha?

Branch has always preview environment. ;) You dont have to screenshot.

how does one look at it?

Gitlab => Operations => Environments

@bryansamuel1 bryansamuel1 merged commit f802827 into develop May 27, 2020
@bryansamuel1 bryansamuel1 deleted the feature/207-SetUpStateForSockets branch May 27, 2020 08:10
@NikoGrano
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Frontend related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants