Update/add grdlandmask parameters and aliases#1423
Merged
michaelgrund merged 22 commits intomainfrom Aug 20, 2021
Merged
Conversation
michaelgrund
added
enhancement
5 tasks
michaelgrund
changed the title
weiji14
reviewed
Aug 11, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Thanks @michaelgrund! By the way, could you swap the order of grdlandmask and grdgradient at https://github.com/GenericMappingTools/pygmt/blame/v0.4.1/doc/api/index.rst#L95-L96? Just noticed they weren't in alphabetical order.
seisman
reviewed
Aug 12, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Aug 16, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Member
Author
|
/format |
seisman
reviewed
Aug 18, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Aug 18, 2021
seisman
added
the
final review call
weiji14
approved these changes
Aug 20, 2021
michaelgrund
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As discussed in #1421 this PR adds further parameters and corresponding aliases to
grdlandmask.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version