Conversation
|
It sounds reasonable to me. Two thoughts:
|
Or we can define two separate dicts (e.g., COMMON_OPTIONS and NONCOMMON_OPTIONS) and another dict that is the combination of both. |
Will do that!
I would go with this option @seisman. Maybe a good first issue to add some comments explaining that the dictionary contains both, common and non-common options? |
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
maxrjones
left a comment
There was a problem hiding this comment.
Just missing one close bracket, otherwise looks good. Thanks!
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
|
I think this PR is ready to merge. Feel free to merge it when you have time @michaelgrund |
* update pygmt/helpers/decorators.py * update docstring in coast Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Description of proposed changes
While working on #1423 I recognized that the -A alias already implemented in
coastas area_thresh is also used in several other modules likegrdlandmask,grdmathandgmtselect. This PR adds area_thresh to the common options list.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version