[Build] Add Windows github runner#4
Conversation
hughperkins
changed the title
|
Note: the markup links wont be fixed until we approve and merge #9 (as well as deciding what to do with that one last link) |
|
Thanks! 🙌 |
|
Maybe I should make the update to the test be on a separate PR 🤔 |
yes that would be nice. |
CharlesMasson
left a comment
CharlesMasson
left a comment
There was a problem hiding this comment.
One comment, LGTM otherwise. 👍
| assert x.grad[1] == -0.25 | ||
|
|
||
|
|
||
| @pytest.mark.flaky(retries=5) |
There was a problem hiding this comment.
Should we add comments to explain why those are needed?
There was a problem hiding this comment.
I think it's self documenting? "these tests are flaky. reason unclear"?
There was a problem hiding this comment.
Yes, I understand this part, but I lack context about whether this is expected and we're fine with it, whether someone has additional context about it, whether it's meant to be investigated and fixed, etc.
There was a problem hiding this comment.
It's not expected, and we're not fine with it, but we don't know how to fix it right now.
There was a problem hiding this comment.
(and there are some much bigger things we want to fix first, like:
- not having to recompile every time we modify the batch size
- recompilations not taking 3 minutes
- start from warm cache not taking 20 seconds)
3 participants
Issue: #
Brief Summary
Add Windows github runner, using github standard runner, with windows server core 2025
copilot:summary
Walkthrough
copilot:walkthrough