[Build] Improve link checker#9
Merged
hughperkins merged 15 commits intomainfrom Jun 5, 2025
Merged
Conversation
duburcqa
reviewed
Jun 4, 2025
duburcqa
reviewed
Jun 4, 2025
duburcqa
reviewed
Jun 4, 2025
duburcqa
reviewed
Jun 4, 2025
duburcqa
reviewed
Jun 5, 2025
| To avoid such implicit casting, you can manually cast your operands to | ||
| desired types, using `ti.cast`. You can control yourself the precision instead of using the default, see | ||
| [Default precisions](#default-precisions). | ||
| [Default precisions](global_settings.md#going-high-precision). |
Contributor
There was a problem hiding this comment.
[Going High Precision](...)
duburcqa
approved these changes
Jun 5, 2025
CharlesMasson
approved these changes
Jun 5, 2025
Collaborator
Author
|
Thanks! |
This was referenced Apr 16, 2026
hughperkins
added a commit
that referenced
this pull request
Apr 26, 2026
Introduce the helper machinery that the per-class to_torch / to_numpy methods will migrate to in subsequent commits. Existing public symbols (can_zerocopy, dlpack_to_torch, invalidate_zerocopy_cache, current_arch_is_cpu) are preserved as deprecated shims so the in-tree pre-rework callers continue to work; they will be removed once every call site is migrated. New surface: - _ZerocopyCache: per-instance container with two independent slots (torch tensor + numpy ndarray), each filled lazily on first access via torch.utils.dlpack.from_dlpack and numpy.from_dlpack respectively. Numpy zero-copy now bypasses torch entirely (closes review #6). - make_zerocopy_cache_if_supported(owner, ...): constructs a cache when zero-copy is supported and registers `owner` with `pyquadrants.cache_holders` so invalidation is wired automatically (closes review #18). - get_zerocopy_torch / get_zerocopy_numpy: thin entry points that implement the always-zerocopy-then-clone semantic (closes review #15, #16, #21) and the Apple Metal double-sync (qd.sync() on read AND torch.mps.synchronize() after .clone()/.to(); closes review #1, #22, #23). Also applies the small lints from the review: - Module-level constant for the torch>2.9.1 MPS bytes_offset probe; drops the pointless lru_cache wrapper around a zero-arg helper (closes review #2). - ASCII '...' instead of Unicode horizontal ellipsis '\u2026' in the docstring (closes review #3). - Top-level imports for numpy and torch (try/except for the no-torch CI case); no per-call lazy imports in the new code path (closes review #7, #9). The deprecated shim still does what the existing per-class methods expect; the new helpers are torch-clean. cache_holders is still empty until the next commits register Ndarray / ScalarField / MatrixField; this commit alone is no-op behaviourally.
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
Existing link checker fails incorrectly on many anchors
... breaks the link check
updates:
... pretty obvuios this should be
#primtive-typescopilot:summary
Walkthrough
copilot:walkthrough