chore: align non-Platform SDK sample targeting#184
Open
alafleur-genetec wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes inactive net8.0-windows conditional ItemGroup blocks from Media SDK, Workspace SDK, and Plugin SDK sample csproj files. These projects only target net481, so the conditional groups were dead code that could never be activated.
Changes:
- Removed
ItemGroup Condition="'$(TargetFramework)' == 'net8.0-windows'"blocks from 12 Media SDK sample projects. - Removed equivalent blocks from 19 Workspace SDK sample projects.
- Removed equivalent blocks from 5 Plugin SDK sample projects.
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Samples/Media SDK/*.csproj (12 files) | Drop unreachable net8.0-windows ItemGroup. |
| Samples/Workspace SDK/*.csproj (19 files) | Drop unreachable net8.0-windows ItemGroup. |
| Samples/Plugin SDK/*.csproj (5 files) | Drop unreachable net8.0-windows ItemGroup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alafleur-genetec
force-pushed
the
fix/remove-dead-net8-itemgroups
branch
from
0d69b13 to
ea48dbc
Compare
alafleur-genetec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net8.0-windowsItemGroups from Media SDK, Workspace SDK, and Plugin SDK sample projects that only targetnet481.net481.