chore: simplify Platform SDK build configurations#185
Open
alafleur-genetec wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Platform SDK sample build matrix by moving from environment-driven/implicit multi-targeting to an explicit configuration model: Debug/Release always target net481, while Debug_NET8/Release_NET8 target net8.0-windows and fail fast when the .NET 8 SDK assemblies aren’t available.
Changes:
- Removed
*_NET481configurations and the prior environment-driven framework selection behavior from sample projects. - Added/standardized
Debug_NET8andRelease_NET8configurations across the Platform SDK samples (including previously “outlier” projects). - Updated build validation to error (not warn) when
_NET8builds cannot find$(GSC_SDK_CORE)\Genetec.Sdk.dll, and updated the README to document the explicit configuration model.
Reviewed changes
Copilot reviewed 69 out of 70 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Samples/Platform SDK/VisitorManagerSample/VisitorManagerSample.csproj | Removes NET481-specific configs; maps _NET8 configs to net8.0-windows and errors if GSC_SDK_CORE\Genetec.Sdk.dll is missing. |
| Samples/Platform SDK/VideoUnitSample/VideoUnitSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/VideoFileQuerySample/VideoFileQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/VideoEventQuerySample/VideoEventQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/UserTaskSample/UserTaskSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/UnusedCredentialQuerySample/UnusedCredentialQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/TriggerAlarmSample/TriggerAlarmSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/TransactionManagerSample/TransactionManagerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/TimeAttendanceSample/TimeAttendanceSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ThumbnailQuerySample/ThumbnailQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ServerSample/ServerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ServerInformationSample/ServerInformationSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/SequenceQuerySample/SequenceQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/SecurityManagerSample/SecurityManagerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ScheduleSample/ScheduleSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ScheduledTaskSample/ScheduledTaskSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/RoleSample/RoleSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ResourceProviderSample/ResourceProviderSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/RequestManagerSample/RequestManagerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ReportExporterSample/ReportExporterSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/RaiseEventSample/RaiseEventSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/PlaySoundSample/PlaySoundSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/PeopleCountingSample/PeopleCountingSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/PartitionSample/PartitionSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/MapSample/MapSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/MacroSample/MacroSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/LprHitQuerySample/LprHitQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/LoginManagerSample/LoginManagerSample.csproj | Updates config mapping/validation; also retains duplicated NET8 property groups (see review comment). |
| Samples/Platform SDK/LoggerSample/LoggerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/LicenseManagerSample/LicenseManagerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/IntrusionDetectionQuerySample/IntrusionDetectionQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/IncidentManagerSample/IncidentManagerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/HealthEventQuerySample/HealthEventQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/HardwareInventoryQuerySample/HardwareInventoryQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/EventToActionSample/EventToActionSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/EventMonitoringSample/EventMonitoringSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/EntityMappingSample/EntityMappingSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/EntityCertificatesManagerSample/EntityCertificatesManagerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/EntityCacheSample/EntityCacheSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/DoorSample/DoorSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/DisplayInTileSample/DisplayInTileSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/DiagnosticServerSample/DiagnosticServerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CustomReportQuerySample/CustomReportQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CustomIconSample/CustomIconSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CustomFieldSample/CustomFieldSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CustomEventSample/CustomEventSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CustomEntitySample/CustomEntitySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CustomCardFormatBuilderSample/CustomCardFormatBuilderSample.csproj | Adds missing _NET8 configurations + validation target to an outlier project. |
| Samples/Platform SDK/CredentialBuilderSample/CredentialBuilderSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CopyConfiguratonSample/CopyConfiguratonSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CardholderSample/CardholderSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CameraSample/CameraSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CameraEventSample/CameraEventSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/CameraConfigurationSample/CameraConfigurationSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AuditTrailsSample/AuditTrailsSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ArchiverRoleSample/ArchiverRoleSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ArchiverEventQuerySample/ArchiverEventQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AlarmMonitoringSample/AlarmMonitoringSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AlarmActivityQuerySample/AlarmActivityQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ActivityTrailsSample/ActivityTrailsSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/ActionMonitoringSample/ActionMonitoringSample.csproj | Adds missing _NET8 configurations + validation target to an outlier project. |
| Samples/Platform SDK/AccessVerifierSample/AccessVerifierSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AccessRuleSample/AccessRuleSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AccessEventMonitoringSample/AccessEventMonitoringSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AccessControlUnitSample/AccessControlUnitSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AccessControlUnitManagerSample/AccessControlUnitManagerSample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AccessControlReportQuerySample/AccessControlReportQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/AccessControlRawEventQuerySample/AccessControlRawEventQuerySample.csproj | Same configuration simplification and _NET8 validation error behavior. |
| Samples/Platform SDK/README.md | Documents the explicit configuration-based framework targeting model and updated troubleshooting/build commands. |
Comments suppressed due to low confidence (1)
Samples/Platform SDK/LoginManagerSample/LoginManagerSample.csproj:87
LoginManagerSample.csprojdefinesDebug_NET8/Release_NET8properties twice (once withCondition="'$(Configuration)|$(Platform)' == 'Debug_NET8|AnyCPU'"/Release_NET8|AnyCPUand again withCondition="'$(Configuration)' == 'Debug_NET8'"/Release_NET8). This duplication is redundant and can lead to accidental property divergence/override later. Consider removing one of the two sets and standardizing on the same pattern used by the other sample projects (singleConfiguration|Platform-conditioned property group per config).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alafleur-genetec
force-pushed
the
chore/simplify-platform-sdk-configurations
branch
from
730f763 to
4669a54
Compare
alafleur-genetec
force-pushed
the
chore/simplify-platform-sdk-configurations
branch
from
4669a54 to
8a6e40f
Compare
alafleur-genetec
force-pushed
the
chore/simplify-platform-sdk-configurations
branch
from
8a6e40f to
ea8bff2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debug/Releasetargetnet481.Debug_NET8/Release_NET8targetnet8.0-windows.Debug_NET481/Release_NET481from the solution and Platform SDK sample projects.Debug/Releasechanged based onGSC_SDK_CORE._NET8configurations fail clearly whenGSC_SDK_CORE\Genetec.Sdk.dllis not available._NET8configuration support to the Platform SDK outlier projects.