Skip to content

fix: empty state component was falsely inverted#1971

Merged
santhoshvai merged 1 commit intodevelopfrom
fix-inverted-empty-list
Feb 14, 2023
Merged

fix: empty state component was falsely inverted#1971
santhoshvai merged 1 commit intodevelopfrom
fix-inverted-empty-list

Conversation

@santhoshvai
Copy link
Copy Markdown
Member

@santhoshvai santhoshvai commented Feb 14, 2023 •
edited
Loading

🎯 Goal

Fixes #1968

🧪 Testing

Set a EmptyStateComponent for message list and pass an empty array as data, it should not be inverted

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@santhoshvai santhoshvai merged commit a83bc7d into develop Feb 14, 2023
@santhoshvai santhoshvai deleted the fix-inverted-empty-list branch February 14, 2023 12:49
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Merged
santhoshvai added a commit that referenced this pull request Feb 14, 2023
@santhoshvai
fix: empty state component was falsely inverted (#1971)
14b667a
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android] Inverted empty state for message list

1 participant

@santhoshvai