Added Infinite loop protection #2883
Conversation
|
addresses #2864 |
|
My dev machine is a Mac so I'm unable to run .net6 in either rider or VStudioMac yet. Since the code was already refactored for net6, i had to checkout the 5.7.0 tag and apply my changes there. Thats the latest version i was able to run on my machine. Someone with Windows is going to have to resolve the merge conflicts as i can't run that code at all. |
|
Seems like you've made this PR off a fairly old revision of |
|
My dev machine is a Mac so I'm unable to run .net6 in either rider or VStudioMac yet. Since the code was already refactored for net6, i had to checkout the 5.7.0 tag and apply my changes there. Thats the latest version i was able to run on my machine. Someone with Windows is going to have to resolve the merge conflicts as i can't run that code at all. |
|
i can try, but no promises. net6 really fubar'd rider |
|
Is it possible to temporarily disable .NET 6 to be able to build the project? |
# Conflicts: # src/GitVersion.Core/Configuration/Abstractions/IBranchConfigurationCalculator.cs # src/GitVersion.Core/Configuration/BranchConfigurationCalculator.cs # src/GitVersion.Core/Core/GitVersionContextFactory.cs
|
no, you refactored the code. 100% not backward compatible. I just had rider merge, anyones guess if it builds because i can't build it on my local anymore |
|
you are going to have to fix whatever is wrong. its well beyond me until rider releases .net6 support which they said they won't until .net6 goes GA |
|
@scphantm you can install the latest EAP of the Rider, that one does support the .net 6.0 (that's how I did the .net 6 PR). |
|
@arturcic , sorry, not happening. I can't afford to risk blowing up the other 30 or so other projects i work on any given day for net6 when i don't have to worry about net6 for at least another 6 months. Above is the code. Pull it and tweak it, copy/paste it, ignore it. do as you like. I've spent as much time on this as i can afford. |
|
@scphantm I can understand that. I will see if we can find some time to check the changes you've done. |
|
You don't have to run with rider. This repo is quite simple to use with |
| { | ||
| using (this.log.IndentLog("Attempting to inherit branch configuration from parent branch")) | ||
| { | ||
| recursiveLevel += 1; |
There was a problem hiding this comment.
check i tinker that we should take an approach view about the margin right in the issue
5 participants
I added recursion breakout if it goes 50 levels deep