Infinite recursion protection #3023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
force-pushed
the
feature/infinite-loop-protection
branch
3 times, most recently
from
bfeb20c to
a09810f
Compare
Refactor recursion protection from the public `GetBranchConfiguration` method to an internal `GetBranchConfigurationInternal` method.
Add fallback for `null` in the configuration for the for `main` and `develop` branch regular expressions.
asbjornu
force-pushed
the
feature/infinite-loop-protection
branch
from
a09810f to
3be6c8f
Compare
arturcic
approved these changes
Mar 3, 2022
Contributor
|
Thank you @asbjornu for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rebased and cleaned up version of #2883.
Description
Implements infinite recursion protection in
BranchConfigurationCalculator.GetBranchConfiguration.Related Issue
Closes #2883. Resolves #2864.
Motivation and Context
Infinite loops and recursions are bad. This tries to avoid it to some extent.
How Has This Been Tested?
No new tests are added to provoke this, but I have no idea how to provoke the behavior described in #2864 and the added code is so simple I'm not sure they need any tests.
Checklist: