test(smokehouse): add numeric comparisons#2356
Merged
Conversation
samccone
reviewed
May 25, 2017
|
|
||
| const PROTOCOL_TIMEOUT_EXIT_CODE = 67; | ||
| const RETRIES = 3; | ||
| const NUMERICAL_EXPECTATION_REGEXP = /(<|>)(\d+)/; |
Contributor
There was a problem hiding this comment.
/^(<|>)(\d+)$/
to tighten it up a bit.
samccone
reviewed
May 26, 2017
| * - Greater than/less than operators, e.g. "<100", ">90" | ||
| * - Regular expressions | ||
| * - Strict equality | ||
| * |
Contributor
There was a problem hiding this comment.
if i am reading your code correctly..
{string|number} actual
{RegExp|string} expected
I think these are the types
Collaborator
Author
There was a problem hiding this comment.
nah it can be any, the Object.is catch-all does boolean and number expectations too, objects will also be passed in but will always be false
paulirish
reviewed
May 26, 2017
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
this is nice. we did this sorta thing in pwmetrics and its been lovely.
one question
|
|
||
| const PROTOCOL_TIMEOUT_EXIT_CODE = 67; | ||
| const RETRIES = 3; | ||
| const NUMERICAL_EXPECTATION_REGEXP = /^(<|>)(\d+)$/; |
Member
There was a problem hiding this comment.
seems like it should handle <= as people would expect it, yah?
Collaborator
Author
There was a problem hiding this comment.
heh yeah I suppose you're right
paulirish
approved these changes
May 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #2353