This repository was archived by the owner on Nov 11, 2022. It is now read-only.
Back-port BEAM changes for display data. #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add boolean-valued display data. * Implement equality for DislpayData.Item * Add ability to override namespace for included subcomponents. * Additional Matchers for testing display data * Update DisplayData inner class privacy (cherry picked from commit 014a9a5)
- Support overriding namespace when adding display data - Support inferring display data type during registration - Add APIs to conditionally register display data if not null/default. - Move additional matchers into DisplayDataMatchers (cherry picked from commit 5da2292)
- Add additional overloads for conditionally registering null display data - Serialize DisplayData using JSON primatives - Fix checkstyle error - Bind generic type parameter in DataflowPipelineTranslator#addDisplayData - Add additional tests for new APIs - Improve readability of DisplayDataTest#populateDisplayData (cherry picked from commit dba82fe)
Expose NeverTrigger as package-private since it is necessary for display data (cherry picked from commit 450dd85)
(cherry picked from commit 77a77c9)
If more than one combineFn have the same namespace, add a sequential suffix. This is necessary because each namespace/key pair must be unique within the transform. Add a `JavaClass` wrapper around a name/simple-name for a class. This is necessary in cases where the class may be serialized to support accessing `DisplayData` since `Class` is not serializable in some cases. (cherry picked from commit b0baa4c)
(cherry picked from commit 2c16bdd)
(cherry picked from commit 359dec8)
Contributor
Author
|
R: @bjchambers |
|
|
||
| package com.google.cloud.dataflow.sdk.options; | ||
|
|
||
| import com.google.api.client.repackaged.com.google.common.base.Objects; |
Contributor
There was a problem hiding this comment.
Should not depend on repackaged versions of dependencies.
Contributor
|
Are there any possibly surprising changes here beyond just cherry-picking and fixing up packaging? I made a quick scan and everything seems sensible, want to make sure there isn't anything that merits further scrutiny. |
Contributor
Author
|
Nope, the process was the cherry-pick each change and fix all the imports (added imports have org.apache.beam.* prefix). I'll take a pass to look for any other repackaged imports. |
Contributor
Author
|
I didn't come across any other bad imports. Please take another look: @bjchambers |
This was referenced May 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.