[BEAM-121] DisplayData API tweaks #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @bjchambers |
Contributor
|
I see test failures. Can you verify that nothing is broken? |
| } | ||
|
|
||
| addList(getProperties(), name, serializedItems); | ||
| List list = MAPPER.convertValue(displayData, List.class); |
swegner
force-pushed
the
displaydata-tweaks
branch
from
6701f4b to
a15ed66
Compare
Contributor
Author
|
Ok, this should build clean now. @bjchambers, can you take another look? Once this is in I'll rebase other PR's on top and we can have another round of feedback on those. |
|
|
||
| JsonNode json = MAPPER.readTree(MAPPER.writeValueAsBytes(data)); | ||
| assertThat(json, hasItem(expectedJson(component.getClass(), "STRING", "string", "\"foobar\""))); | ||
| assertThat(json, hasItem(expectedJson(component.getClass(), "INTEGER", "long", "1234"))); |
Contributor
There was a problem hiding this comment.
This test may be easier to read (and verify it matches expectations) if it just has the expected value as a single string, or a string for each value.
Contributor
Author
|
I've addressed all feedback so far. Please take another look. @bjchambers |
Contributor
|
LGTM |
Member
|
@swegner, did we backport this? (Cc: @bjchambers) |
Contributor
Author
|
I haven't done any backporting work for recent PRs-- I'm not quite familiar with the process. I'll work with @bjchambers on this. |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
Contributor
Author
|
Backported via GoogleCloudPlatform/DataflowJavaSDK#216 |
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
Format licenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.